[6.1] Disable flaky CancelAsyncConnections test on kerberos#4333
Merged
Conversation
To resolve, run: git cherry-pick 4a4bd9d
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates manual test gating to avoid running a flaky CancelAsyncConnections scenario in certain environments (Azure, Kerberos, and Managed Instance) by introducing a reusable Kerberos-negative condition in DataTestUtility.
Changes:
- Added
DataTestUtility.IsNotKerberosTestas the inverse ofIsKerberosTest. - Updated
AsyncCancelledConnectionsTest.CancelAsyncConnectionsconditional execution to also exclude Kerberos and Managed Instance environments (in addition to Azure).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncCancelledConnectionsTest.cs | Adjusts test attribute conditions intended to skip the flaky test in more environments. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs | Adds a helper property to simplify “non-Kerberos” conditional checks. |
cheenamalhotra
approved these changes
Jun 4, 2026
paulmedynski
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #4311
Test utility improvements:
IsNotKerberosTesttoDataTestUtilityto simplify checking for non-Kerberos environments.Test attribute updates:
AsyncCancelledConnectionsTestto use[ConditionalTheory]and skip execution on Azure, Kerberos, and Managed Instance pipelines by includingIsNotKerberosTestandIsNotManagedInstancein the test conditions.