Skip to content

PR Pipeline - Azure + AE#4338

Merged
benrr101 merged 21 commits into
mainfrom
dev/russellben/pr-azure
Jun 11, 2026
Merged

PR Pipeline - Azure + AE#4338
benrr101 merged 21 commits into
mainfrom
dev/russellben/pr-azure

Conversation

@benrr101

@benrr101 benrr101 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds to the PR pipeline in the previous PR #4308 and adds the following test jobs:

  • SqlClient Manual test sets 123 against Azure
  • SqlClient Manual test sets AE against localhost (in release mode)

Testing

@benrr101 benrr101 added this to the 7.1.0-preview2 milestone Jun 3, 2026
Copilot AI review requested due to automatic review settings June 3, 2026 21:06
@benrr101 benrr101 added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Jun 3, 2026
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jun 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the new PR validation pipeline to run additional SqlClient manual test coverage in CI-like PR validation scenarios, specifically adding Azure SQL manual test runs and an Always Encrypted (AE) manual test run in Release configuration.

Changes:

  • Adds SqlClient manual test set 123 execution against Azure SQL, alongside existing localhost manual coverage.
  • Adds a localhost Always Encrypted manual test run (TestSet=AE) forced to Release configuration.
  • Simplifies PR pipeline templates by removing PR-specific wrapper step templates and switching PR jobs/stages to directly use the shared eng/pipelines/common/steps/* templates.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/tests/ManualTests/BulkCopy/CopyAllFromReaderConnectionCloseOnEventAsync.cs Skips this BulkCopy manual test on Azure servers via an additional IsNotAzureServer condition.
eng/pipelines/pr/stages/test-stages.yml Adds Azure manual test execution for set 123, and adds localhost AE manual execution (AE) in Release mode.
eng/pipelines/pr/jobs/test-sqlclientmanual-job.yml Parameterizes manual test jobs by config/test set; adds conditional local server setup and passes TestSet to build.proj.
eng/pipelines/pr/jobs/test-buildproj-job.yml Updates job bootstrap to use shared install/restore steps and inlines the build.proj test invocation.
eng/pipelines/pr/stages/pack-stage.yml Replaces PR-specific dotnet install wrapper with shared common install + tool restore steps.
eng/pipelines/pr/steps/pack-buildproj-step.yml Renames the task display name to clarify it performs packing.
eng/pipelines/pr/steps/test-buildproj-step.yml Deleted (previously a PR-specific wrapper step for running build.proj test targets).
eng/pipelines/pr/steps/install-dotnet.yml Deleted (previously a PR-specific wrapper around the common install-dotnet and tool restore steps).
eng/pipelines/pr/steps/build-buildproj-step.yml Deleted (previously a PR-specific wrapper step for running build.proj build targets).

Comment thread eng/pipelines/pr/jobs/test-buildproj-job.yml
Comment thread eng/pipelines/pr/jobs/test-sqlclientmanual-job.yml
Copilot AI review requested due to automatic review settings June 4, 2026 22:42
@benrr101 benrr101 marked this pull request as ready for review June 4, 2026 22:43
@benrr101 benrr101 requested a review from a team as a code owner June 4, 2026 22:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment thread eng/pipelines/pr/jobs/test-buildproj-job.yml
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Jun 5, 2026
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.62%. Comparing base (5ac26c9) to head (631d50c).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
- Coverage   66.50%   64.62%   -1.89%     
==========================================
  Files         285      280       -5     
  Lines       43311    66162   +22851     
==========================================
+ Hits        28806    42759   +13953     
- Misses      14505    23403    +8898     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread eng/pipelines/pr/jobs/test-buildproj-job.yml Outdated
@github-project-automation github-project-automation Bot moved this from In review to Waiting for customer in SqlClient Board Jun 5, 2026
@benrr101

benrr101 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@paulmedynski I'm going to assume it has to do wit the branch not being up to date with main and didn't have the config.jsonc changes. Merge has been pushed, so fingers crossed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Comment thread eng/pipelines/pr/jobs/test-sqlclientmanual-job.yml
paulmedynski
paulmedynski previously approved these changes Jun 9, 2026
Copilot AI review requested due to automatic review settings June 9, 2026 15:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comment thread eng/pipelines/pr/jobs/test-sqlclientmanual-job.yml
Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs Outdated
Comment thread eng/pipelines/pr/stages/test-stages.yml
Comment thread eng/pipelines/pr/stages/test-stages.yml
@github-project-automation github-project-automation Bot moved this from In review to Waiting for customer in SqlClient Board Jun 9, 2026
@cheenamalhotra cheenamalhotra added the Author attention needed PRs that require author to respond or make updates to PR. label Jun 10, 2026
Copilot AI review requested due to automatic review settings June 10, 2026 23:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

@benrr101 benrr101 removed the Author attention needed PRs that require author to respond or make updates to PR. label Jun 10, 2026
@benrr101 benrr101 moved this from Waiting for customer to In review in SqlClient Board Jun 10, 2026
@benrr101 benrr101 requested a review from cheenamalhotra June 10, 2026 23:37
@benrr101 benrr101 merged commit 348f007 into main Jun 11, 2026
356 checks passed
@benrr101 benrr101 deleted the dev/russellben/pr-azure branch June 11, 2026 19:33
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants