Skip to content

Tests | Add Flaky test details to ConnectionFailoverTests#4341

Merged
cheenamalhotra merged 2 commits into
mainfrom
dev/cheena/flaky-tests
Jun 10, 2026
Merged

Tests | Add Flaky test details to ConnectionFailoverTests#4341
cheenamalhotra merged 2 commits into
mainfrom
dev/cheena/flaky-tests

Conversation

@cheenamalhotra

Copy link
Copy Markdown
Member

There are some regularly failing tests from ConnectionFailoverTests class, this PR adds failures/error message details for further investigation.

Copilot AI review requested due to automatic review settings June 4, 2026 19:07
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jun 4, 2026
@cheenamalhotra cheenamalhotra marked this pull request as ready for review June 4, 2026 19:07
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner June 4, 2026 19:07
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Jun 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ConnectionFailoverTests (simulated server unit tests) to capture additional context about recurring flaky failures, aiming to aid later diagnosis of intermittent CI issues in failover scenarios.

Changes:

  • Annotates existing flaky theories/facts with inline failure summaries (assert diffs, timeouts, and SqlException details).
  • Adds TODO blocks near assertions/open calls to preserve observed failure output for investigation.
  • Marks an additional theory (TransientFault_RetryDisabled_WithUserProvidedPartner_ShouldFail_NotFailover) as Category=flaky with a brief failure note.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.55%. Comparing base (bfbdd30) to head (8eb1089).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4341      +/-   ##
==========================================
- Coverage   66.69%   64.55%   -2.14%     
==========================================
  Files         284      279       -5     
  Lines       43238    66069   +22831     
==========================================
+ Hits        28836    42653   +13817     
- Misses      14402    23416    +9014     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra cheenamalhotra added this to the 7.1.0-preview2 milestone Jun 4, 2026
@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Jun 9, 2026
@cheenamalhotra cheenamalhotra merged commit e46104d into main Jun 10, 2026
303 of 304 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Jun 10, 2026
@cheenamalhotra cheenamalhotra deleted the dev/cheena/flaky-tests branch June 10, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants