Improve EnclaveDiffieHellmanInfo.Size

[jnyrup]

Description

Parenthesize ?? as + binds stronger

Perhaps this let's us uncomment the following Debug.Asserts?
Let me know if I should try uncomment the asserts and see if CI is green.

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.cs

Lines 156 to 157 in 7721c98

	// TODO(GH-3604): Fix this failing assertion.
	// Debug.Assert(offset == attestationInfo.Length, $"{offset} == {attestationInfo.Length}");

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.cs

Lines 211 to 212 in 7721c98

	// TODO(GH-3604): Fix this failing assertion.
	// Debug.Assert(offset == attestationInfo.Length);

Issues

Testing

Guidelines

Please review the contribution guidelines before submitting a pull request:

• Contributing
• Code of Conduct
• Best Practices
• Coding Style
• Review Process

[paulmedynski]

Please uncomment the Debug.Assert()s that you mentioned, and let's see what happens :) The PR pipelines compile and run the tests in Debug configuration.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.04%. Comparing base (3488b36) to head (eceb1d3).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...a/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs	0.00%	1 Missing ⚠️
.../SqlClient/AzureAttestationBasedEnclaveProvider.cs	0.00%	1 Missing ⚠️
...Data/SqlClient/VirtualSecureModeEnclaveProvider.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4346      +/-   ##
==========================================
- Coverage   66.55%   64.04%   -2.51%     
==========================================
  Files         285      280       -5     
  Lines       43311    66162   +22851     
==========================================
+ Hits        28824    42371   +13547     
- Misses      14487    23791    +9304     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	64.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.