Wrap prId variable in url.#4350
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a PowerShell string interpolation edge case in the GitHub→Azure DevOps sync pipeline script so the ADO REST API PATCH URL always includes the intended PR id.
Changes:
- Wraps
$prIdin${}when building the PATCH URI to avoid PowerShell parsing$prId?api-version...as a different variable name.
paulmedynski
left a comment
There was a problem hiding this comment.
Can we also ensure this automation is running for the release branches nightly?
|
Also exclude this pipeline from triggering all PR validation workflows. |
|
Sure, I'll take those in a follow-up PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
==========================================
- Coverage 66.69% 64.05% -2.64%
==========================================
Files 284 280 -4
Lines 43238 66160 +22922
==========================================
+ Hits 28836 42379 +13543
- Misses 14402 23781 +9379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This path had never been hit before. Just needs a wrapper for the variable name.