Skip to content

Wrap prId variable in url.#4350

Merged
mdaigle merged 1 commit into
mainfrom
dev/mdaigle/ado-sync-fix
Jun 9, 2026
Merged

Wrap prId variable in url.#4350
mdaigle merged 1 commit into
mainfrom
dev/mdaigle/ado-sync-fix

Conversation

@mdaigle

@mdaigle mdaigle commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This path had never been hit before. Just needs a wrapper for the variable name.

Copilot AI review requested due to automatic review settings June 9, 2026 19:00
@mdaigle mdaigle requested a review from a team as a code owner June 9, 2026 19:00
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Jun 9, 2026
@mdaigle mdaigle added this to the 7.1.0-preview2 milestone Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a PowerShell string interpolation edge case in the GitHub→Azure DevOps sync pipeline script so the ADO REST API PATCH URL always includes the intended PR id.

Changes:

  • Wraps $prId in ${} when building the PATCH URI to avoid PowerShell parsing $prId?api-version... as a different variable name.

@paulmedynski paulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also ensure this automation is running for the release branches nightly?

@cheenamalhotra

Copy link
Copy Markdown
Member

Also exclude this pipeline from triggering all PR validation workflows.

@mdaigle mdaigle enabled auto-merge (squash) June 9, 2026 21:02
@mdaigle

mdaigle commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Sure, I'll take those in a follow-up PR.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.05%. Comparing base (bfbdd30) to head (15ab06e).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4350      +/-   ##
==========================================
- Coverage   66.69%   64.05%   -2.64%     
==========================================
  Files         284      280       -4     
  Lines       43238    66160   +22922     
==========================================
+ Hits        28836    42379   +13543     
- Misses      14402    23781    +9379     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle merged commit f50d21c into main Jun 9, 2026
304 of 305 checks passed
@mdaigle mdaigle deleted the dev/mdaigle/ado-sync-fix branch June 9, 2026 21:39
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants