[Release/6.1] Fix fetching signature verification result from cache#4356
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ports #4339 to release/6.1 to fix a security-sensitive bug where CMK signature verification cache lookups could incorrectly treat a cached false (verification failure) as a cache hit/success.
Changes:
- Introduces a tri-state
SignatureVerificationResultto distinguish cache miss vs cachedfalse. - Updates
SqlSecurityUtility.VerifyColumnMasterKeySignatureto re-verify only on cache miss and to honor cached failures. - Adds
SignatureVerificationCacheTeststo cover cached success, cached failure (regression), and cache miss behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SignatureVerificationCacheTests.cs | Adds regression/unit coverage for cache hit/miss and cached-false scenarios. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs | Switches CMK signature verification flow to use the tri-state cache API correctly. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SignatureVerificationCache.cs | Implements tri-state cache result and refactors cache get/add + trimming logic. |
paulmedynski
approved these changes
Jun 11, 2026
mdaigle
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #4339 to release/6.1