Fix SqlCommand.Cancell null ref exception#4372
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a NullReferenceException in SqlCommand.Cancel() when the command has no associated connection (Connection == null), aligning the method with expected no-op behavior in that scenario.
Changes:
- Prevent
SqlCommand.Cancel()tracing from dereferencing_activeConnectionwhen it isnull. - Add a functional test asserting
Cancel()does not throw whenConnectionisnull.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.cs | Makes Cancel() correlation tracing null-safe for ClientConnectionId when _activeConnection is not set. |
| src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlCommandTest.cs | Adds regression coverage ensuring SqlCommand.Cancel() is a no-op when Connection is null. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4372 +/- ##
==========================================
- Coverage 65.39% 63.45% -1.95%
==========================================
Files 285 280 -5
Lines 43331 66193 +22862
==========================================
+ Hits 28337 42000 +13663
- Misses 14994 24193 +9199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apoorvdeshmukh
approved these changes
Jun 18, 2026
paulmedynski
approved these changes
Jun 18, 2026
This was referenced Jun 25, 2026
This was referenced Jun 26, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.