Address @jonathanpeppers review: TCP-only enum, add ToSocketSpec tests

- Remove LocalAbstract, LocalReserved, LocalFilesystem from AdbProtocol enum (add later when needed)
- Simplify ToSocketSpec and TryParse to only handle TCP
- Add ToSocketSpec unit tests: HighPort, LowPort, InvalidProtocol_Throws
- Add TryParse test: NonTcpProtocol_ReturnsNull
- Remove 3 non-TCP TryParse tests
- Update PublicAPI files (remove 3 enum entries per TFM)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: rmarinho

src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/net10.0/PublicAPI.Unshipped.txt

@@ -191,9 +191,7 @@ Xamarin.Android.Tools.AdbPortSpec.Protocol.get -> Xamarin.Android.Tools.AdbProto
 Xamarin.Android.Tools.AdbPortSpec.Protocol.init -> void
 Xamarin.Android.Tools.AdbPortSpec.ToSocketSpec() -> string!
 Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalAbstract = 1 -> Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalFilesystem = 3 -> Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalReserved = 2 -> Xamarin.Android.Tools.AdbProtocol
+
 Xamarin.Android.Tools.AdbProtocol.Tcp = 0 -> Xamarin.Android.Tools.AdbProtocol
 override Xamarin.Android.Tools.AdbPortSpec.ToString() -> string!
 static Xamarin.Android.Tools.AdbPortSpec.TryParse(string? socketSpec) -> Xamarin.Android.Tools.AdbPortSpec?

src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt

@@ -191,9 +191,7 @@ Xamarin.Android.Tools.AdbPortSpec.Protocol.get -> Xamarin.Android.Tools.AdbProto
 Xamarin.Android.Tools.AdbPortSpec.Protocol.init -> void
 Xamarin.Android.Tools.AdbPortSpec.ToSocketSpec() -> string!
 Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalAbstract = 1 -> Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalFilesystem = 3 -> Xamarin.Android.Tools.AdbProtocol
-Xamarin.Android.Tools.AdbProtocol.LocalReserved = 2 -> Xamarin.Android.Tools.AdbProtocol
+
 Xamarin.Android.Tools.AdbProtocol.Tcp = 0 -> Xamarin.Android.Tools.AdbProtocol
 override Xamarin.Android.Tools.AdbPortSpec.ToString() -> string!
 static Xamarin.Android.Tools.AdbPortSpec.TryParse(string? socketSpec) -> Xamarin.Android.Tools.AdbPortSpec?

src/Xamarin.Android.Tools.AndroidSdk/Runners/AdbPortSpec.cs

@@ -15,9 +15,6 @@ public record AdbPortSpec (AdbProtocol Protocol, int Port)
 	/// </summary>
 	public string ToSocketSpec () => Protocol switch {
 		AdbProtocol.Tcp => $"tcp:{Port}",
-		AdbProtocol.LocalAbstract => $"localabstract:{Port}",
-		AdbProtocol.LocalReserved => $"localreserved:{Port}",
-		AdbProtocol.LocalFilesystem => $"localfilesystem:{Port}",
 		_ => throw new ArgumentOutOfRangeException (nameof (Protocol), Protocol, $"Unsupported ADB protocol: {Protocol}"),
 	};
 
@@ -42,9 +39,6 @@ public record AdbPortSpec (AdbProtocol Protocol, int Port)
 
 		var protocol = protocolStr.ToLowerInvariant () switch {
 			"tcp" => (AdbProtocol?) AdbProtocol.Tcp,
-			"localabstract" => AdbProtocol.LocalAbstract,
-			"localreserved" => AdbProtocol.LocalReserved,
-			"localfilesystem" => AdbProtocol.LocalFilesystem,
 			_ => null,
 		};
 

src/Xamarin.Android.Tools.AndroidSdk/Runners/AdbProtocol.cs

@@ -8,8 +8,8 @@ namespace Xamarin.Android.Tools;
 /// </summary>
 public enum AdbProtocol
 {
+	/// <summary>
+	/// TCP socket spec, e.g. "tcp:5000".
+	/// </summary>
 	Tcp,
-	LocalAbstract,
-	LocalReserved,
-	LocalFilesystem,
 }

tests/Xamarin.Android.Tools.AndroidSdk-Tests/AdbRunnerTests.cs

@@ -878,39 +878,9 @@ public void AdbPortSpec_TryParse_ValidTcp ()
 	}
 
 	[Test]
-	public void AdbPortSpec_TryParse_ValidLocalAbstract ()
+	public void AdbPortSpec_TryParse_NonTcpProtocol_ReturnsNull ()
 	{
-		var spec = AdbPortSpec.TryParse ("localabstract:9222");
-		if (spec is null) {
-			Assert.Fail ("Expected non-null AdbPortSpec");
-			return;
-		}
-		Assert.AreEqual (AdbProtocol.LocalAbstract, spec.Protocol);
-		Assert.AreEqual (9222, spec.Port);
-	}
-
-	[Test]
-	public void AdbPortSpec_TryParse_ValidLocalReserved ()
-	{
-		var spec = AdbPortSpec.TryParse ("localreserved:1234");
-		if (spec is null) {
-			Assert.Fail ("Expected non-null AdbPortSpec");
-			return;
-		}
-		Assert.AreEqual (AdbProtocol.LocalReserved, spec.Protocol);
-		Assert.AreEqual (1234, spec.Port);
-	}
-
-	[Test]
-	public void AdbPortSpec_TryParse_ValidLocalFilesystem ()
-	{
-		var spec = AdbPortSpec.TryParse ("localfilesystem:8080");
-		if (spec is null) {
-			Assert.Fail ("Expected non-null AdbPortSpec");
-			return;
-		}
-		Assert.AreEqual (AdbProtocol.LocalFilesystem, spec.Protocol);
-		Assert.AreEqual (8080, spec.Port);
+		Assert.IsNull (AdbPortSpec.TryParse ("localabstract:9222"));
 	}
 
 	[Test]
@@ -963,10 +933,24 @@ public void AdbPortSpec_ToSocketSpec_Tcp ()
 	}
 
 	[Test]
-	public void AdbPortSpec_ToSocketSpec_LocalAbstract ()
+	public void AdbPortSpec_ToSocketSpec_HighPort ()
+	{
+		var spec = new AdbPortSpec (AdbProtocol.Tcp, 65535);
+		Assert.AreEqual ("tcp:65535", spec.ToSocketSpec ());
+	}
+
+	[Test]
+	public void AdbPortSpec_ToSocketSpec_LowPort ()
+	{
+		var spec = new AdbPortSpec (AdbProtocol.Tcp, 1);
+		Assert.AreEqual ("tcp:1", spec.ToSocketSpec ());
+	}
+
+	[Test]
+	public void AdbPortSpec_ToSocketSpec_InvalidProtocol_Throws ()
 	{
-		var spec = new AdbPortSpec (AdbProtocol.LocalAbstract, 9222);
-		Assert.AreEqual ("localabstract:9222", spec.ToSocketSpec ());
+		var spec = new AdbPortSpec ((AdbProtocol) 99, 5000);
+		Assert.Throws<System.ArgumentOutOfRangeException> (() => spec.ToSocketSpec ());
 	}
 
 	[Test]