Add AvdManagerRunner.ListDeviceProfilesAsync() for device profile enumeration by rmarinho · Pull Request #325 · dotnet/android-tools

rmarinho · 2026-04-08T16:35:53Z

Summary

Add a method to enumerate available AVD device profiles (hardware definitions) using avdmanager list device --compact.

Uses the --compact flag for clean, script-friendly output (one device ID per line) instead of the verbose multi-line format.

Changes

Added AvdDeviceProfile record (Id) in Models/
Added AvdManagerRunner.ListDeviceProfilesAsync() — runs avdmanager list device --compact and parses output
Internal ParseCompactDeviceListOutput() static method for testability
5 unit tests covering multiple profiles, empty output, Windows newlines, blank lines
Updated PublicAPI.Unshipped.txt for both net10.0 and netstandard2.0

Closes #321

Copilot

Pull request overview

Adds first-class support in Xamarin.Android.Tools.AndroidSdk for enumerating AVD device profiles (hardware definitions) by running avdmanager list device, returning strongly-typed results for consumers (IDE extensions, GUI tools, CLIs).

Changes:

Introduced AvdDeviceProfile record model (Id, Name, Oem, Tag).
Added AvdManagerRunner.ListDeviceProfilesAsync() plus ParseDeviceListOutput() to parse avdmanager list device output.
Added unit tests for parsing behavior across multiple profiles, empty/header-only output, missing name fallback, and Windows newlines; updated PublicAPI unshipped entries for both TFMs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/Xamarin.Android.Tools.AndroidSdk-Tests/AvdManagerRunnerTests.cs	Adds parsing-focused unit tests for device profile enumeration.
src/Xamarin.Android.Tools.AndroidSdk/Runners/AvdManagerRunner.cs	Implements the new API to run `avdmanager list device` and parse results.
src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt	Declares the new public API surface for netstandard2.0.
src/Xamarin.Android.Tools.AndroidSdk/PublicAPI/net10.0/PublicAPI.Unshipped.txt	Declares the new public API surface for net10.0.
src/Xamarin.Android.Tools.AndroidSdk/Models/AvdDeviceProfile.cs	Adds the new public model type representing a device profile.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

+	/// <summary>
+	/// Lists available device profiles (hardware definitions) using <c>avdmanager list device --compact</c>.
+	/// </summary>
+	public async Task<IReadOnlyList<AvdDeviceProfile>> ListDeviceProfilesAsync (CancellationToken cancellationToken = default)
+	{


+/// <summary>
+/// Represents a hardware device profile (e.g., "pixel_7", "Nexus 5X") from <c>avdmanager list device --compact</c>.
+/// </summary>
+public record AvdDeviceProfile (string Id);


+Xamarin.Android.Tools.AvdManagerRunner.ListDeviceProfilesAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<System.Collections.Generic.IReadOnlyList<Xamarin.Android.Tools.AvdDeviceProfile!>!>!
+Xamarin.Android.Tools.AvdDeviceProfile
+Xamarin.Android.Tools.AvdDeviceProfile.AvdDeviceProfile(string! Id) -> void
+Xamarin.Android.Tools.AvdDeviceProfile.Id.get -> string!
+Xamarin.Android.Tools.AvdDeviceProfile.Id.init -> void


+Xamarin.Android.Tools.AvdManagerRunner.ListDeviceProfilesAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<System.Collections.Generic.IReadOnlyList<Xamarin.Android.Tools.AvdDeviceProfile!>!>!
+Xamarin.Android.Tools.AvdDeviceProfile
+Xamarin.Android.Tools.AvdDeviceProfile.AvdDeviceProfile(string! Id) -> void
+Xamarin.Android.Tools.AvdDeviceProfile.Id.get -> string!
+Xamarin.Android.Tools.AvdDeviceProfile.Id.init -> void


…meration Add ListDeviceProfilesAsync() and ParseDeviceListOutput() to AvdManagerRunner. Runs 'avdmanager list device' and parses the output into AvdDeviceProfile records (Id, Name, Oem, Tag). Includes AvdDeviceProfile record model, 6 unit tests, and PublicAPI entries for both net10.0 and netstandard2.0. Closes #321 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jonathanpeppers · 2026-04-30T13:29:45Z

/review

github-actions · 2026-04-30T13:30:57Z

✅ Android Tools PR Reviewer completed successfully!

The gh-aw safe_outputs framework requires at least one create_pull_request_review_comment before submit_pull_request_review will work. When the reviewer gives a clean LGTM with no inline comments, the review silently fails with "No review context set." Update the workflow prompt and SKILL.md to require at least one inline comment on every review, even for clean PRs. ### Example - PR that triggered the bug: #325 - Broken workflow run: https://github.com/dotnet/android-tools/actions/runs/25168175699 - See the `safe_outputs` → `Process Safe Outputs` step: `"Submitting PR review (body-only, no inline comments)"` → `"No review context set - cannot submit review"` - Completion comment (with no actual review posted): #325 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

rmarinho · 2026-04-30T14:59:18Z

/review

github-actions · 2026-04-30T15:00:25Z

✅ Android Tools PR Reviewer completed successfully!

github-actions

✅ LGTM — Clean, well-structured addition

Summary: Adds ListDeviceProfilesAsync() to AvdManagerRunner and a companion AvdDeviceProfile record, with solid test coverage.

Positives:

Follows existing patterns exactly: ProcessUtils.CreateProcessStartInfo, StartProcess, ThrowIfFailed, logger invocation — mirrors ListAvdsAsync and DeleteAvdAsync.
AvdDeviceProfile is a positional record in its own file under Models/ — matches AvdInfo, SdkPackage, etc.
Parser is internal static for testability without exposing implementation detail.
Return type is IReadOnlyList<T> — correct per API design conventions.
ThrowIfFailed includes both stderr and stdout — actually improves on the older ListAvdsAsync pattern.
PublicAPI files updated for both net10.0 and netstandard2.0.
Tests cover multiple profiles, empty output, Windows \r\n newlines, blank lines, and return type — good coverage.
init accessor on netstandard2.0 works via the existing IsExternalInit.cs polyfill.

CI: license/cla ✅ passed. No build/test CI runs visible on this check — ensure the full build pipeline passes before merge.

No issues found. One 💡 observation posted inline about a positive pattern worth backporting.

Generated by Android Tools PR Reviewer for issue #325 · ● 1.6M

github-actions · 2026-04-30T15:05:33Z

+		logger.Invoke (TraceLevel.Verbose, "Running: avdmanager list device --compact");
+		var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken, environmentVariables).ConfigureAwait (false);
+
+		ProcessUtils.ThrowIfFailed (exitCode, "avdmanager list device --compact", stderr, stdout);


🤖 💡 Pattern — Nice: passing both stderr and stdout to ThrowIfFailed follows the recommended convention for including all output in error diagnostics. Worth noting that the existing ListAvdsAsync (line 46) only passes stderr — a follow-up PR could bring it in line with this improved pattern.

Rule: Include stdout in error diagnostics (Postmortem #48)

rmarinho requested review from jonathanpeppers and simonrozsival as code owners April 8, 2026 16:35

Copilot AI review requested due to automatic review settings April 8, 2026 16:35

Copilot started reviewing on behalf of rmarinho April 8, 2026 16:36 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

jonathanpeppers requested changes Apr 13, 2026

View reviewed changes

Comment thread src/Xamarin.Android.Tools.AndroidSdk/Runners/AvdManagerRunner.cs Outdated

rmarinho force-pushed the features/321-list-device-profiles branch from 02bb295 to 8b87399 Compare April 30, 2026 13:04

rmarinho requested a review from Copilot April 30, 2026 13:22

Copilot started reviewing on behalf of rmarinho April 30, 2026 13:22 View session

This comment was marked as outdated.

Sign in to view

Copilot AI reviewed Apr 30, 2026

View reviewed changes

rmarinho force-pushed the features/321-list-device-profiles branch from 8b87399 to ca2c633 Compare April 30, 2026 13:26

rmarinho requested a review from jonathanpeppers April 30, 2026 13:28

jonathanpeppers mentioned this pull request Apr 30, 2026

Fix reviewer not posting body-only reviews #352

Merged

Merge branch 'main' into features/321-list-device-profiles

1a02529

github-actions Bot reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AvdManagerRunner.ListDeviceProfilesAsync() for device profile enumeration#325

Add AvdManagerRunner.ListDeviceProfilesAsync() for device profile enumeration#325
rmarinho wants to merge 2 commits intomainfrom
features/321-list-device-profiles

rmarinho commented Apr 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Copilot AI left a comment

Uh oh!

Uh oh!

jonathanpeppers commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

rmarinho commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rmarinho commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment was marked as outdated.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jonathanpeppers commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmarinho commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

✅ LGTM — Clean, well-structured addition

Uh oh!

github-actions Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rmarinho commented Apr 8, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading