From d528f04ec5788321383047f09ed61c13e55787de Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Thu, 30 Apr 2026 08:59:19 -0500 Subject: [PATCH] Fix reviewer not posting body-only reviews The gh-aw safe_outputs framework requires at least one create_pull_request_review_comment before submit_pull_request_review will work. When the reviewer gives a clean LGTM with no inline comments, the review silently fails with "No review context set." Update the workflow prompt and SKILL.md to require at least one inline comment on every review, even for clean PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/skills/android-tools-reviewer/SKILL.md | 2 +- .github/workflows/android-tools-reviewer.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/skills/android-tools-reviewer/SKILL.md b/.github/skills/android-tools-reviewer/SKILL.md index 8feeaa4d..7ded5441 100644 --- a/.github/skills/android-tools-reviewer/SKILL.md +++ b/.github/skills/android-tools-reviewer/SKILL.md @@ -85,7 +85,7 @@ Post your findings directly: - **Inline comments** on specific lines of the diff with the severity, category, and explanation. - **Review summary** with the overall verdict (✅ LGTM, ⚠️ Needs Changes, or ❌ Reject), issue counts by severity, and positive callouts. -If no issues found **and CI is green**, submit with at most one or two 💡 suggestions and a positive summary. +If no issues found **and CI is green**, submit with one or two 💡 suggestions on key implementation lines and a positive summary. **Always post at least one inline comment** — the review submission framework requires it. **Copilot-authored PRs:** If the PR author is `Copilot` (the GitHub Copilot coding agent) and the verdict is ⚠️ Needs Changes or ❌ Reject, prefix the review summary with `@copilot ` so the comment automatically triggers Copilot to address the feedback. Do NOT add the prefix for ✅ LGTM verdicts. diff --git a/.github/workflows/android-tools-reviewer.md b/.github/workflows/android-tools-reviewer.md index 377a0d32..d55aac0c 100644 --- a/.github/workflows/android-tools-reviewer.md +++ b/.github/workflows/android-tools-reviewer.md @@ -50,6 +50,7 @@ A maintainer commented `/review` on this pull request. Perform a thorough code r ## Constraints +- **Always post at least one inline review comment**, even for clean PRs — add a brief 💡 observation on a key implementation line. The review framework requires at least one inline comment to submit the review. - Only comment on added/modified lines visible in the diff. - One issue per inline comment. - If the same issue appears many times, flag it once listing all affected files.