Fix reviewer not posting body-only reviews#352
Merged
jonathanpeppers merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
The gh-aw safe_outputs framework requires at least one create_pull_request_review_comment before submit_pull_request_review will work. When the reviewer gives a clean LGTM with no inline comments, the review silently fails with "No review context set." Update the workflow prompt and SKILL.md to require at least one inline comment on every review, even for clean PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the android-tools reviewer guidance to avoid gh-aw safe_outputs failing to submit body-only PR reviews by requiring at least one inline review comment per run.
Changes:
- Add a workflow constraint requiring at least one inline review comment, even for clean PRs
- Update the reviewer SKILL guidance to require at least one inline comment on key lines even when CI is green
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/android-tools-reviewer.md | Adds a constraint to force at least one inline comment so review submission has required context |
| .github/skills/android-tools-reviewer/SKILL.md | Updates reviewer instructions to ensure at least one inline comment is always created |
simonrozsival
approved these changes
Apr 30, 2026
jonathanpeppers
deleted the
jonathanpeppers/fix-reviewer-body-only-review
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the android-tools-reviewer workflow silently failing to post review comments when the PR is clean (LGTM, no inline comments).
Root Cause
The
gh-awsafe_outputs framework requires at least onecreate_pull_request_review_commentcall beforesubmit_pull_request_reviewwill work. When the reviewer agent gives a clean LGTM with zero inline comments, the review fails silently with:Despite this, the workflow reports "success" because the warning isn't treated as a fatal error.
Example
safe_outputs→Process Safe Outputsstep:"Submitting PR review (body-only, no inline comments)"→"No review context set - cannot submit review"Why dotnet/android works fine
The dotnet/android reviewer workflow uses identical
safe-outputsconfiguration (v0.68.3, same handler config). However, dotnet/android PRs always generate at least one inline comment due to the larger/more complex codebase — so this bug never triggers there. Every successful dotnet/android reviewer run hascreate_pull_request_review_commententries beforesubmit_pull_request_review.Fix
Update the workflow prompt and SKILL.md to require at least one inline review comment on every review, even for clean PRs (e.g., a brief 💡 observation on a key implementation line). This works around the
gh-awframework limitation.