Skip to content

Commit 43a455d

Browse files
[copilot] allow copilot-setup-steps.yml to fail (#10261)
We found Copilot can go off track if: * Copilot commits a build error (of any kind). * You comment suggesting how to fix the build error. * Copilot setup steps will now fail, and Copilot can't fix it! So, once you are in this state, you can't really get Copilot back on track unless you manually fix it. Going forward, we should: * Allow the "build" step to fail * Upload the logs as an artifact Copilot should be able to do its work with a failing build.
1 parent cfc263a commit 43a455d

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/copilot-setup-steps.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,16 @@ jobs:
1818
with:
1919
dotnet-version: '9.x'
2020

21-
- name: Run jenkins build
21+
- name: Run android build
22+
id: android-build
23+
continue-on-error: true
2224
run: |
2325
make jenkins PREPARE_CI=1 PREPARE_AUTOPROVISION=1 CONFIGURATION=Debug
2426
timeout-minutes: 60
2527

2628
- name: Upload logs
2729
uses: actions/upload-artifact@v4
28-
if: failure()
30+
if: steps.android-build.outcome == 'failure'
2931
with:
3032
name: copilot-artifacts
3133
path: |

0 commit comments

Comments
 (0)