Skip to content

Commit 7010ecb

Browse files
Enable CoreCLR runtime pack for android-arm (armeabi-v7a)
Enable the CoreCLR runtime flavor for the armeabi-v7a ABI, following the same pattern as android-arm64 and android-x64. Changes: - Set SupportCoreCLR=True for armeabi-v7a in Ndk.projitems.in - Add ApiLevelNonMono metadata and corresponding property/placeholder - Add Microsoft.Android.Runtime.CoreCLR.36.1.android-arm to workload manifest Depends on dotnet/runtime#127225 and dotnet/runtime#126838 (API level 24). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2712742 commit 7010ecb

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

build-tools/scripts/Ndk.projitems.in

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<AndroidNdkApiLevel_X86 Condition=" '$(AndroidNdkApiLevel_X86)' == '' ">@NDK_X86_API_NET@</AndroidNdkApiLevel_X86>
1212
<AndroidNdkApiLevel_X86_64 Condition=" '$(AndroidNdkApiLevel_X86_64)' == '' ">@NDK_X86_64_API@</AndroidNdkApiLevel_X86_64>
1313
<AndroidNdkApiLevel_X64 Condition=" '$(AndroidNdkApiLevel_X64)' == '' ">@NDK_X86_64_API_NET@</AndroidNdkApiLevel_X64>
14+
<AndroidNdkApiLevelNonMono_Arm Condition=" '$(AndroidNdkApiLevelNonMono_Arm)' == '' ">@NDK_ARMEABI_V7_API_NON_MONO@</AndroidNdkApiLevelNonMono_Arm>
1415
<AndroidNdkApiLevelNonMono_Arm64 Condition=" '$(AndroidNdkApiLevelNonMono_Arm64)' == '' ">@NDK_ARM64_V8A_API_NON_MONO@</AndroidNdkApiLevelNonMono_Arm64>
1516
<AndroidNdkApiLevelNonMono_X64 Condition=" '$(AndroidNdkApiLevelNonMono_X64)' == '' ">@NDK_X86_64_API_NON_MONO@</AndroidNdkApiLevelNonMono_X64>
1617
</PropertyGroup>
@@ -21,9 +22,10 @@
2122
Condition=" $(AndroidSupportedTargetJitAbisForConditionalChecks.Contains (':armeabi-v7a:')) ">
2223
<ApiLevel>$(AndroidNdkApiLevel_ArmV7a)</ApiLevel>
2324
<ApiLevelNET>$(AndroidNdkApiLevel_Arm)</ApiLevelNET>
25+
<ApiLevelNonMono>$(AndroidNdkApiLevelNonMono_Arm)</ApiLevelNonMono>
2426
<AndroidRID>android-arm</AndroidRID>
2527
<SupportMonoVM>True</SupportMonoVM>
26-
<SupportCoreCLR>False</SupportCoreCLR>
28+
<SupportCoreCLR>True</SupportCoreCLR>
2729
<SupportNativeAOT>False</SupportNativeAOT>
2830
</AndroidSupportedTargetJitAbi>
2931

build-tools/xaprepare/xaprepare/Steps/Step_GenerateFiles.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ GeneratedFile Get_Ndk_projitems (Context context)
257257
{ "@NDK_X86_64_API@", BuildAndroidPlatforms.NdkMinimumAPI.ToString () },
258258
{ "@NDK_X86_64_API_NET@", BuildAndroidPlatforms.NdkMinimumAPI.ToString () },
259259
{ "@NDK_ARM64_V8A_API_NON_MONO@", BuildAndroidPlatforms.NdkMinimumNonMonoAPI },
260+
{ "@NDK_ARMEABI_V7_API_NON_MONO@", BuildAndroidPlatforms.NdkMinimumNonMonoAPI },
260261
{ "@NDK_X86_64_API_NON_MONO@", BuildAndroidPlatforms.NdkMinimumNonMonoAPI },
261262
};
262263

src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"Microsoft.Android.Runtime.Mono.37.android-arm64",
1313
"Microsoft.Android.Runtime.Mono.37.android-x86",
1414
"Microsoft.Android.Runtime.Mono.37.android-x64",
15+
"Microsoft.Android.Runtime.CoreCLR.37.android-arm",
1516
"Microsoft.Android.Runtime.CoreCLR.37.android-arm64",
1617
"Microsoft.Android.Runtime.CoreCLR.37.android-x64",
1718
"Microsoft.Android.Runtime.NativeAOT.37.android-arm64",
@@ -78,6 +79,10 @@
7879
"kind": "framework",
7980
"version": "@WORKLOAD_VERSION@"
8081
},
82+
"Microsoft.Android.Runtime.CoreCLR.37.android-arm": {
83+
"kind": "framework",
84+
"version": "@WORKLOAD_VERSION@"
85+
},
8186
"Microsoft.Android.Runtime.CoreCLR.37.android-arm64": {
8287
"kind": "framework",
8388
"version": "@WORKLOAD_VERSION@"

0 commit comments

Comments
 (0)