Temporarily allow native registration attributes in trimmable typemap

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: simonrozsival

src/Microsoft.Android.Sdk.TrimmableTypeMap/Scanner/JavaPeerScanner.cs

@@ -210,19 +210,13 @@ void ScanAssembly (AssemblyIndex index, Dictionary<(string ManagedName, string A
 
 			var fullName = MetadataTypeNameResolver.GetFullName (typeDef, index.Reader);
 
-			// [JniAddNativeMethodRegistrationAttribute] is not supported by the trimmable typemap
-			// by design (see XA4251). Detect the attribute *before* any per-type filters below
-			// (array type, no JNI name, etc.) so the diagnostic fires uniformly regardless of
-			// whether the type would otherwise have ended up in the typemap.
-			//
-			// Skip the per-method walk entirely for the overwhelmingly common case where
-			// the assembly doesn't even reference the attribute type — the per-assembly
-			// flag was computed cheaply in AssemblyIndex.Build.
-			if (index.MayUseJniAddNativeMethodRegistrationAttribute &&
-			    !IsBuiltInJniAddNativeMethodRegistrationType (fullName, index) &&
-			    HasJniAddNativeMethodRegistrationAttribute (typeDef, index)) {
-				logger?.LogJniAddNativeMethodRegistrationAttributeError (fullName);
-			}
+			// Temporarily allow [JniAddNativeMethodRegistrationAttribute] while we investigate
+			// which scenarios fail later in the trimmable typemap pipeline.
+			// if (index.MayUseJniAddNativeMethodRegistrationAttribute &&
+			//     !IsBuiltInJniAddNativeMethodRegistrationType (fullName, index) &&
+			//     HasJniAddNativeMethodRegistrationAttribute (typeDef, index)) {
+			// 	logger?.LogJniAddNativeMethodRegistrationAttributeError (fullName);
+			// }
 
 			// Determine the JNI name and whether this is a known Java peer.
 			// Priority:

tests/Microsoft.Android.Sdk.TrimmableTypeMap.Tests/Generator/TrimmableTypeMapGeneratorTests.cs

@@ -74,17 +74,6 @@ public void Execute_WithTestFixtures_ProducesOutputs ()
 		Assert.Contains (result.GeneratedAssemblies, a => a.Name == "_TestFixtures.TypeMap");
 	}
 
-	[Fact]
-	public void Execute_WithJniAddNativeMethodRegistrationAttribute_ReportsXA4251 ()
-	{
-		// TestFixtures.HandWrittenNativeRegistrationPeer carries [JniAddNativeMethodRegistrationAttribute].
-		// The trimmable typemap does not support that attribute by design — the orchestrator must
-		// emit XA4251 so MSBuild fails the build via HasLoggedErrors.
-		using var peReader = CreateTestFixturePEReader ();
-		CreateGenerator ().Execute (new List<(string, PEReader)> { ("TestFixtures", peReader) }, new Version (11, 0), new HashSet<string> ());
-		Assert.Contains (logMessages, m => m.Contains ("XA4251") && m.Contains ("HandWrittenNativeRegistrationPeer"));
-	}
-
 	[Fact]
 	public void Execute_CollectsDeferredRegistrationTypes_ForAllApplicationAndInstrumentationSubtypes ()
 	{

tests/Microsoft.Android.Sdk.TrimmableTypeMap.Tests/Scanner/JavaPeerScannerTests.cs

@@ -60,42 +60,6 @@ public void Scan_MarksFrameworkAssemblyPeers ()
 		Assert.All (peers, p => Assert.False (p.GenerateArrayEntries, $"{p.ManagedTypeName} should not emit array entries unless referenced from a non-framework assembly."));
 	}
 
-	[Fact]
-	public void Scan_JniAddNativeMethodRegistrationAttribute_LogsError ()
-	{
-		// The trimmable typemap refuses to support [JniAddNativeMethodRegistrationAttribute]
-		// by design (XA4251). The scanner reports each offending type via the logger.
-		var errors = new List<string> ();
-		var logger = new RecordingLogger (errors);
-
-		using var scanner = new JavaPeerScanner (logger: logger);
-		using var peReader = new PEReader (File.OpenRead (TestFixtureAssemblyPath));
-		var reader = peReader.GetMetadataReader ();
-		var assemblyName = reader.GetString (reader.GetAssemblyDefinition ().Name);
-		_ = scanner.Scan (new List<(string, PEReader)> { (assemblyName, peReader) });
-
-		Assert.Contains (errors, e => e.Contains ("HandWrittenNativeRegistrationPeer"));
-		Assert.Contains (errors, e => e.Contains ("NonPeerNativeRegistration"));
-		Assert.DoesNotContain (errors, e => e.Contains ("OtherNamespaceNativeRegistration"));
-		Assert.DoesNotContain (errors, e => e.Contains ("MyHelper"));
-	}
-
-	sealed class RecordingLogger (List<string> errors) : ITrimmableTypeMapLogger
-	{
-		public void LogNoJavaPeerTypesFound () { }
-		public void LogJavaPeerScanInfo (int assemblyCount, int peerCount) { }
-		public void LogGeneratingJcwFilesInfo (int jcwPeerCount, int totalPeerCount) { }
-		public void LogDeferredRegistrationTypesInfo (int typeCount) { }
-		public void LogGeneratedTypeMapAssemblyInfo (string assemblyName, int typeCount) { }
-		public void LogGeneratedRootTypeMapInfo (int assemblyReferenceCount) { }
-		public void LogGeneratedTypeMapAssembliesInfo (int assemblyCount) { }
-		public void LogGeneratedJcwFilesInfo (int sourceCount) { }
-		public void LogRootingManifestReferencedTypeInfo (string javaTypeName, string managedTypeName) { }
-		public void LogManifestReferencedTypeNotFoundWarning (string javaTypeName) { }
-		public void LogJniAddNativeMethodRegistrationAttributeError (string managedTypeName) =>
-			errors.Add ($"XA4251: {managedTypeName}");
-	}
-
 	[Fact]
 	public void Scan_TypeMetadata_IsCorrect ()
 	{