-
Notifications
You must be signed in to change notification settings - Fork 569
[TrimmableTypeMap] Improve array handling #11238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simonrozsival
wants to merge
18
commits into
main
Choose a base branch
from
dev/simonrozsival/trimmable-array-typemap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bafa7e5
[Mono.Android] Trimmable typemap: fix JavaCast/JavaAs behavior
simonrozsival a804994
[TrimmableTypeMap] Scanner fixes: invoker ctor, keyword types, array …
simonrozsival c5062a6
[Tests] Re-enable 7 trimmable typemap tests
simonrozsival bd207f4
[TrimmableTypeMap] Generator: emit per-rank array TypeMap entries
simonrozsival 956a999
[TrimmableTypeMap] Runtime: array typemap fork on IsDynamicCodeSupported
simonrozsival b12791a
[TrimmableTypeMap] Address PR feedback
simonrozsival ce92d44
[TrimmableTypeMap] Trim verbose doc comments
simonrozsival b19a2ce
[TrimmableTypeMap] Wire up merged-universe + array entries path
simonrozsival e29ca74
[TrimmableTypeMap] Tighten comments in shared+arrays IL emit
simonrozsival 90b0b8f
[TrimmableTypeMap] Reject multi-dim arrays in TryGetArrayType
simonrozsival 86eaeff
[TrimmableTypeMap] Inline rank sentinel name generation
simonrozsival 6c814ce
[TrimmableTypeMap] Drop CompositeStringTypeReadOnlyDictionary
simonrozsival f4f288a
[TrimmableTypeMap] Use shared rank anchors in Mono.Android
simonrozsival 1df33a7
[TrimmableTypeMap] Simplify TryGetArrayType
simonrozsival b53a07b
[TrimmableTypeMap] Unify Initialize IL emit paths
simonrozsival f4564df
[TrimmableTypeMap] Two small simplifications
simonrozsival 8e95788
[TrimmableTypeMap] Fold model setup into a single object initializer
simonrozsival af650a5
[TrimmableTypeMap] Drop stale 'TypeDef was emitted' check + message
simonrozsival File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 💡 Documentation — The doc comment says "
[L<jni>;-shaped TypeMap entries", but the design choice here is specifically to use the bare element JNI name as the key (no[L...;wrapping). The testBuild_EmitArrayEntries_KeyIsElementJniNamedocuments this explicitly. Consider rewording to avoid confusion:Rule: Comments explain "why", not "what" — and shouldn't contradict the implementation