Remove Mono.Android trim suppressions#11261
Draft
simonrozsival wants to merge 10 commits intomainfrom
Draft
Conversation
Enable IsAotCompatible so Mono.Android reports trim and AOT analyzer diagnostics during builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the Java.Interop submodule to include trim annotations for peer activation and native registration. This points at dotnet/java-interop#1416. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove trim suppressions from Java conversion and array paths by modeling constructor requirements and avoiding untraceable runtime generic construction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Surface untraceable runtime reflection with RUC and propagate DAM through native registration and peer activation paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
force-pushed
the
dev/simonrozsival/10794-trimming-aot-warnings
branch
from
59303c4 to
e783332
Compare
Update the Java.Interop submodule to include IsAotCompatible in Java.Interop.csproj. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace IL3050 pragmas with explicit RequiresDynamicCode boundaries and keep generated bindings on typed array marshaling paths.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Consume the Java.Interop follow-up that removes the broad JniTypeSignatureAttribute generator change while keeping the trim/AOT annotation work.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Opt the shipped Mono.Android runtime support assemblies into IsAotCompatible and consume the Java.Interop shipped-library analyzer opt-ins.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Consume the Java.Interop cleanup that removes remaining Java.Runtime.Environment trim suppressions after enabling AOT compatibility.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10794.
Depends on dotnet/java-interop#1416.
This removes the targeted
UnconditionalSuppressMessageattributes fromsrc/Mono.Android, excluding the explicitly out-of-scopeTypeManager.csandManagedTypeManager.cssuppressions.Changes are split into logical commits:
IsAotCompatibleforMono.Android.csprojso trim/AOT analyzer diagnostics are reported.Validation:
./dotnet-local.sh build src/Mono.Android/Mono.Android.csproj -v:minimal -nr:false