[build] Audit xaprepare third-party notices#11267
Open
jonathanpeppers wants to merge 1 commit intomainfrom
Open
[build] Audit xaprepare third-party notices#11267jonathanpeppers wants to merge 1 commit intomainfrom
jonathanpeppers wants to merge 1 commit intomainfrom
Conversation
Remove 8 stale TPN entries: - Java.Interop.cs: Remove 7 sub-notices no longer in Java.Interop (gityf/crc, javaparser, Mono.Linq.Expressions, mono/csharp, mono/LineEditor, mono/Options, HtmlAgilityPack). Simplify from ThirdPartyNoticeGroup to standalone ThirdPartyNotice. - Xamarin.Android.Build.Tasks.cs: Remove fsharp/fsharp (not a dependency; we only support F# customer projects) Add 1 missing TPN entry: - libunwind.cs: Add entry for libunwind/libunwind submodule (external/libunwind, MIT license, shipped in product) Regenerate THIRD-PARTY-NOTICES.TXT with updated entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates xaprepare’s Third Party Notice (TPN) source-of-truth entries to better reflect current dependencies, removing stale notices and adding a missing notice for libunwind (an external/ submodule) so the generated notices remain accurate.
Changes:
- Added a new
libunwindTPN entry gated onincludeExternalDeps. - Removed the stale
fsharp/fsharpTPN entry from Xamarin.Android.Build.Tasks external dependency group. - Simplified Java.Interop TPNs by removing the external-dependencies group and leaving only the
dotnet/java-interopnotice.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build-tools/xaprepare/xaprepare/ThirdPartyNotices/libunwind.cs | Adds a new [TPN] notice for the external/libunwind submodule with its license file path. |
| build-tools/xaprepare/xaprepare/ThirdPartyNotices/Xamarin.Android.Build.Tasks.cs | Removes the fsharp/fsharp notice from the external dependency group and deletes the corresponding notice class. |
| build-tools/xaprepare/xaprepare/ThirdPartyNotices/Java.Interop.cs | Removes the Java.Interop external dependency group and retains only the dotnet/java-interop notice entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1: Audit and update the xaprepare Third Party Notice entries to match actual dependencies.
Phase 2 will replace the xaprepare/C# TPN generation code with a Copilot skill, reducing code to maintain.
Changes
Removed 8 stale TPN entries
From
Java.Interop.cs— Java.Interop's.gitmodulesnow only hasexternal/xamarin-android-tools, and its ownThirdPartyNotices.txtonly listsJetBrains/kotlin. These 7 sub-notices are no longer dependencies:gityf/crcjavaparser/javaparserjbevain/mono.linq.expressionsmono/csharpmono/LineEditormono/Optionszzzprojects/HtmlAgilityPackSimplified from
ThirdPartyNoticeGroupto a standaloneThirdPartyNoticefor justdotnet/java-interopitself.From
Xamarin.Android.Build.Tasks.cs:fsharp/fsharp— F# is not a dependency; dotnet/android only supports F# customer projectsAdded 1 missing TPN entry
libunwind.cs—external/libunwindsubmodule (MIT license), compiled via CMake and shipped in product native libsRegenerated
THIRD-PARTY-NOTICES.TXTupdated with the corrected entries