Stop generating dead Java.Interop.__TypeRegistrations#11664
Closed
Copilot wants to merge 10 commits into
Closed
Conversation
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Stop generating dead Java.Interop.__TypeRegistrations class
Stop generating dead Java.Interop.__TypeRegistrations
Jun 16, 2026
simonrozsival
left a comment
simonrozsival
left a comment
Member
There was a problem hiding this comment.
@copilot address this code review
| packageLookup = new Dictionary<string, List<Converter<string, Type?>>> (StringComparer.Ordinal); | ||
| } | ||
|
|
||
| public static void RegisterPackage (string package, Converter<string, Type> lookup) |
Member
There was a problem hiding this comment.
this method should throw NotSupportedException
| throw new ArgumentNullException ("lookup"); | ||
| } | ||
|
|
||
| public static void RegisterPackages (string[] packages, Converter<string, Type?>[] lookups) |
Member
There was a problem hiding this comment.
this method should throw NotSupportedException
simonrozsival
left a comment
simonrozsival
left a comment
Member
There was a problem hiding this comment.
@copilot it's necessary to open a PR in the dotnet/java-interop repo with the generator changes
Contributor
Author
|
@simonrozsival I've opened a new pull request, #11666, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding generator still emitted
Java.Interop.__TypeRegistrations, but the runtime fallback that consumed it has been removed. The generated class and its package lookup registrations are now dead code in every binding assembly.__TypeRegistrationsgeneration call.RegisterPackages(),Lookup(...), and per-package lookup converters.Generator baselines
Java.Interop.__TypeRegistrations.csfromexpected.xajifixtures.Mono.Android.projitemscompile entries.Runtime compatibility
Java.Interop.TypeManagerregistration APIs as compatibility no-ops.