Skip to content

Remove stale commented-out input-size-limit code in AssemblyCompression.cs #11677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 2 commits into from
Jun 17, 2026
Merged

Remove stale commented-out input-size-limit code in AssemblyCompression.cs #11677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ecc707
Initial plan
Copilot Jun 17, 2026
08d8006
[Xamarin.Android.Build.Tasks] Remove stale commented-out input-size-l…
Copilot Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Xamarin.Android.Build.Tasks/Utilities/AssemblyCompression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ public void SetData (string sourcePath, uint descriptorIndex)

const uint CompressedDataMagic = 0x5A4C4158; // 'XALZ', little-endian

// TODO: consider making it configurable via an MSBuild property, would be more flexible this way
//
// Arbitrary limit of the input assembly size, to clamp down on memory allocation. Our unlinked Mono.Android.dll
// assembly (the biggest one we have) is currently (May 2020) around 27MB, so let's bump the value to 30MB times
// two - it should be more than enough for most needs.
//public const ulong InputAssemblySizeLimit = 60 * 1024 * 1024;

static readonly ArrayPool<byte> bytePool = ArrayPool<byte>.Shared;

static CompressionResult Compress (AssemblyData data, string outputFilePath)
Expand All @@ -71,9 +64,6 @@ static CompressionResult Compress (AssemblyData data, string outputFilePath)
var fi = new FileInfo (data.SourcePath);
if (!fi.Exists)
throw new InvalidOperationException ($"File '{data.SourcePath}' does not exist");
// if ((ulong)fi.Length > InputAssemblySizeLimit) {
// return CompressionResult.InputTooBig;
// }

data.DestinationPath = outputFilePath;
data.SourceSize = checked((uint)fi.Length);
Expand Down
Loading