CR fixes

Author: adamzip

src/Microsoft.DotNet.Darc/DarcLib/GitHubClient.cs

@@ -924,7 +924,7 @@ public async Task<IList<Review>> GetLatestPullRequestReviewsAsync(string pullReq
 
         IGitHubClient client = GetClient(owner, repo);
         var pullRequestReviewsUri = ApiUrls.PullRequestReviews(owner, repo, id);
-        string cacheKey = $"{owner}_{repo}_id";
+        string cacheKey = $"{owner}_{repo}_{id}";
 
         var pullRequestReviews = await RequestResourceUsingEtagsAsync<GithubPullRequestReviews, List<PullRequestReview>>(
             cacheKey,

src/Microsoft.DotNet.Darc/DarcLib/Helpers/GithubResourceConverters.cs

@@ -37,12 +37,11 @@ internal static GithubPullRequestReviews ConvertPullRequestReviews(IEnumerable<P
                 TranslateReviewState(r.State.Value),
                 r.PullRequestUrl,
                 r.User.Login,
-                r.SubmittedAt))
-            .ToArray();
-
+                r.SubmittedAt));
+                
         return new GithubPullRequestReviews
         {
-            Reviews = reviews
+            Reviews = [.. reviews]
         };
     }
 

src/ProductConstructionService/ProductConstructionService.Common/RedisCacheClient.cs

@@ -14,6 +14,7 @@ internal class RedisCacheClient : IRedisCacheClient
 {
     private readonly IRedisCacheFactory _factory;
     private readonly ILogger<RedisCacheClient> _logger;
+    private readonly TimeSpan _defaultExpiration = TimeSpan.FromDays(15);
 
     public RedisCacheClient(IRedisCacheFactory factory, ILogger<RedisCacheClient> logger)
     {
@@ -30,7 +31,7 @@ public async Task<bool> TrySetAsync<T>(string key, T value, TimeSpan? expiration
     {
         try
         {
-            await _factory.Create<T>(key).SetAsync(value, expiration);
+            await _factory.Create<T>(key).SetAsync(value, expiration ?? _defaultExpiration);
         }
         catch (Exception ex)
         {