CR changes

Author: adamzip

src/Microsoft.DotNet.Darc/DarcLib/Helpers/GithubResourceConverters.cs

@@ -32,13 +32,13 @@ internal static Models.PullRequest ConvertPullRequest(Octokit.PullRequest pr)
 
     internal static GithubPullRequestReviews ConvertPullRequestReviews(IEnumerable<PullRequestReview> pullRequestReviews)
     {
-        IEnumerable<GithubReview> reviews = pullRequestReviews
+        var reviews = pullRequestReviews
             .Select(r => new GithubReview(
                 TranslateReviewState(r.State.Value),
                 r.PullRequestUrl,
                 r.User.Login,
                 r.SubmittedAt))
-            .ToList();
+            .ToArray();
 
         return new GithubPullRequestReviews
         {

src/Microsoft.DotNet.Darc/DarcLib/Models/GitHub/GithubPullRequestReviews.cs

@@ -7,7 +7,7 @@
 namespace Microsoft.DotNet.DarcLib.Models;
 public class GithubPullRequestReviews : IGithubEtagResource
 {
-    public IEnumerable<GithubReview> Reviews { get; set; }
+    public IReadOnlyCollection<GithubReview> Reviews { get; set; }
     public string Etag { get; set; }
 
 }

test/Microsoft.DotNet.DarcLib.Tests/GitHubClientTests.cs

@@ -164,7 +164,6 @@ protected override async Task<T> RequestResourceUsingEtagsAsync<T, K>(
         IGitHubClient client,
         Func<K, T> resourceConverter)
     {
-        await Task.FromResult<T>(null);
         if (typeof(K) == typeof(List<PullRequestReview>))
         {
             var match = ReviewsUriPattern.Match(resourceUri.ToString());
@@ -174,9 +173,9 @@ protected override async Task<T> RequestResourceUsingEtagsAsync<T, K>(
             var key = Tuple.Create(owner, repo, id);
             if (_reviewData.TryGetValue(key, out var reviews))
             {
-                return resourceConverter((K)(object)reviews);
+                return await Task.FromResult(resourceConverter((K)(object)reviews));
             }
-            return resourceConverter((K)(object)new List<PullRequestReview>());
+            return await Task.FromResult(resourceConverter((K)(object)new List<PullRequestReview>()));
         }
         throw new NotImplementedException($"The test client has no implementation for the requested resources of type {typeof(K)}");
     }