[main] Source code updates from dotnet/dotnet by dotnet-maestro[bot] · Pull Request #17057 · dotnet/arcade

dotnet-maestro · 2026-06-27T02:12:04Z

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Subscription: b472297a-0d16-41ea-91af-ee5ed4325178
Build: 20260625.2 (320196)
Date Produced: June 25, 2026 12:44:12 PM UTC
Commit: 1358fe9202089df7bdb79282a191c9dbbb773a06
Commit Diff: 1d49107...1358fe9
Branch: main

Associated changes in source repos

Diff the source with this PR branch

darc vmr diff --name-only https://github.com/dotnet/dotnet:1358fe9202089df7bdb79282a191c9dbbb773a06..https://github.com/dotnet/arcade:darc-main-10490dc9-62d5-4cac-b54b-c78376a45147

Diff: https://github.com/dotnet/dotnet/compare/088599371eb4f4778c89e1c3b2bffcb24d05ed1b..1358fe9202089df7bdb79282a191c9dbbb773a06 From: dotnet/dotnet@0885993 To: dotnet/dotnet@1358fe9 [[ commit created by automation ]]

No dependency updates to commit [[ commit created by automation ]]

dotnet-maestro · 2026-06-27T02:12:06Z

Note

VMR PRs included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro · 2026-06-28T02:11:27Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro · 2026-06-29T02:11:03Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro · 2026-06-30T02:17:44Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

am11 · 2026-06-30T15:39:57Z

All failures are related to vswhere.exe

System.TypeInitializationException : The type initializer for 'Microsoft.DotNet.Build.Tasks.Workloads.Tests.TestBase' threw an exception.\r\n---- System.Exception : vswhere.exe not found. Visual Studio is required to build the test project.

@mmitche, is this a known infra issue? Would be nice to get this in before arcade->VMR flow (to avoid overwriting eng/common changes made in VMR the PR carries)

am11 · 2026-06-30T15:45:12Z

FWIW, nativeaot package uses this standalone mechanism https://github.com/dotnet/runtime/blob/999ca22160f03e33dd970c93373dde5ad7fd1158/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.targets#L132-L159 it works with .NET engineering infra (those 10-15 components using PublishAot during VMR build across 4 repos..) as well as for Windows users out in the wild. So I think convergence with that infra would make sense.

mmitche · 2026-06-30T16:17:04Z

All failures are related to vswhere.exe
System.TypeInitializationException : The type initializer for 'Microsoft.DotNet.Build.Tasks.Workloads.Tests.TestBase' threw an exception.\r\n---- System.Exception : vswhere.exe not found. Visual Studio is required to build the test project.
@mmitche, is this a known infra issue? Would be nice to get this in before arcade->VMR flow (to avoid overwriting eng/common changes made in VMR the PR carries)

Unlikely to be an infra issue and more likely to be some intersection between VS and the SDK.

mmitche · 2026-06-30T16:18:32Z

Looking further, it looks like these are tests that @joeloff added. They proibably wont' work in Helix due to not having VS. Should we exclude them from PR runs?

dotnet-maestro · 2026-07-01T02:14:07Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro · 2026-07-02T02:10:18Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

ViktorHofer · 2026-07-02T13:29:45Z

@joeloff PTAL

dotnet-maestro · 2026-07-03T02:12:31Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

am11 · 2026-07-03T07:43:11Z

+
+            if (!File.Exists(vswhere))
+            {
+                throw new Exception("vswhere.exe not found. Visual Studio is required to build the test project.");


The way runtime handles NativeAOT tests is by relying on the publish test artifacts step which runs before Send to Helix step. If something went wrong during the publishing, CI fails all the same and we can see the result. The tests only run on Helix.

I think we should do the same here. For now, lets just skip it:

Suggested change

throw new Exception("vswhere.exe not found. Visual Studio is required to build the test project.");

Assert.Skip("Skipping because vswhere.exe is unavailable on this machine.");

dotnet-maestro · 2026-07-04T02:11:34Z

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

Ignore this and merge this PR as usual without waiting for the new changes.
Once merged, Maestro will create a new codeflow PR with the new changes.
Close this PR and wait for Maestro to open a new one with old and new changes included.
You will lose any manual changes made in this PR.
You can also manually trigger the new codeflow right away by running:
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178
```
Force a codeflow into this PR at your own risk if you want the new changes.
User commits made to this PR might be reverted.
```
darc trigger-subscriptions --id b472297a-0d16-41ea-91af-ee5ed4325178 --force
```

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-maestro Bot added 2 commits June 27, 2026 02:11

Update dependencies from build 320196

6b73a7a

No dependency updates to commit [[ commit created by automation ]]

am11 reviewed Jul 3, 2026

View reviewed changes

	throw new Exception("vswhere.exe not found. Visual Studio is required to build the test project.");
	Assert.Skip("Skipping because vswhere.exe is unavailable on this machine.");

Uh oh!

Conversation

dotnet-maestro Bot commented Jun 27, 2026

From https://github.com/dotnet/dotnet

Associated changes in source repos

Uh oh!

dotnet-maestro Bot commented Jun 27, 2026

Uh oh!

dotnet-maestro Bot commented Jun 28, 2026

Uh oh!

dotnet-maestro Bot commented Jun 29, 2026

Uh oh!

dotnet-maestro Bot commented Jun 30, 2026

Uh oh!

am11 commented Jun 30, 2026

Uh oh!

am11 commented Jun 30, 2026

Uh oh!

mmitche commented Jun 30, 2026

Uh oh!

mmitche commented Jun 30, 2026

Uh oh!

dotnet-maestro Bot commented Jul 1, 2026

Uh oh!

dotnet-maestro Bot commented Jul 2, 2026

Uh oh!

ViktorHofer commented Jul 2, 2026

Uh oh!

dotnet-maestro Bot commented Jul 3, 2026

Uh oh!

am11 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

dotnet-maestro Bot commented Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants