Update existing extension methods to use the extension member syntax. Where applicable, update extension methods to extension properties.

Author: commonsensesoftware

.editorconfig

@@ -122,8 +122,10 @@ dotnet_diagnostic.ASP0023.severity = none # Route conflict detected between rout
 
 # TEMP: temporary suppression for false positives
 # BUG: https://github.com/dotnet/sdk/issues/51681
+# BUG: https://github.com/dotnet/sdk/issues/51716
 [*Extensions.cs]
 dotnet_diagnostic.CA1034.severity = none
+dotnet_diagnostic.CA1708.severity = none
 
 # test settings
 

examples/AspNet/OData/AdvancedODataWebApiExample/Controllers/OrdersController.cs

@@ -10,7 +10,7 @@ public class OrdersController : ApiController
 {
     // GET ~/api/orders
     // GET ~/api/orders?api-version=1.0
-    public IHttpActionResult Get( ApiVersion version ) => 
+    public IHttpActionResult Get( ApiVersion version ) =>
         Ok( new[] { new Order() { Id = 1, Customer = $"Customer v{version}" } } );
 
     // GET ~/api/orders/{id}

examples/AspNet/OData/AdvancedODataWebApiExample/Controllers/PeopleController.cs

@@ -35,32 +35,32 @@ public IHttpActionResult Get( ODataQueryOptions<Person> options, ApiVersion vers
     [ODataRoute( "{id}" )]
     public IHttpActionResult Get( int id, ODataQueryOptions<Person> options, ApiVersion version ) =>
         Ok( new Person()
-        { 
-            Id = id, 
-            FirstName = "Bill", 
-            LastName = "Mei", 
-            Email = "bill.mei@somewhere.com", 
+        {
+            Id = id,
+            FirstName = "Bill",
+            LastName = "Mei",
+            Email = "bill.mei@somewhere.com",
             Phone = "555-555-5555",
         } );
 
     // PATCH ~/api/people/{id}?api-version=2.0
     [MapToApiVersion( "2.0" )]
     [ODataRoute( "{id}" )]
-    public IHttpActionResult Patch( 
-        int id, 
-        Delta<Person> delta, 
-        ODataQueryOptions<Person> options, 
+    public IHttpActionResult Patch(
+        int id,
+        Delta<Person> delta,
+        ODataQueryOptions<Person> options,
         ApiVersion version )
     {
         if ( !ModelState.IsValid )
             return BadRequest( ModelState );
 
         var person = new Person()
-        { 
-            Id = id, 
-            FirstName = "Bill", 
-            LastName = "Mei", 
-            Email = "bill.mei@somewhere.com", 
+        {
+            Id = id,
+            FirstName = "Bill",
+            LastName = "Mei",
+            Email = "bill.mei@somewhere.com",
             Phone = "555-555-5555",
         };
 

examples/AspNet/OData/BasicODataWebApiExample/Controllers/PeopleController.cs

@@ -16,9 +16,9 @@ public class PeopleController : ODataController
     [ODataRoute]
     public IHttpActionResult Get( ODataQueryOptions<Person> options ) =>
         Ok( new Person[]
-        { 
+        {
             new()
-            { 
+            {
                 Id = 1,
                 FirstName = "Bill",
                 LastName = "Mei",
@@ -30,11 +30,11 @@ public IHttpActionResult Get( ODataQueryOptions<Person> options ) =>
     // GET ~/api/people/{id}?api-version=[1.0|2.0]
     [ODataRoute( "{id}" )]
     public IHttpActionResult Get( int id, ODataQueryOptions<Person> options ) =>
-        Ok( new Person() 
-        { 
-            Id = id, 
-            FirstName = "Bill", 
-            LastName = "Mei", 
+        Ok( new Person()
+        {
+            Id = id,
+            FirstName = "Bill",
+            LastName = "Mei",
             Email = "bill.mei@somewhere.com",
             Phone = "555-555-5555",
         } );
@@ -50,11 +50,11 @@ public IHttpActionResult Patch( int id, Delta<Person> delta, ODataQueryOptions<P
         }
 
         var person = new Person()
-        { 
-            Id = id, 
-            FirstName = "Bill", 
-            LastName = "Mei", 
-            Email = "bill.mei@somewhere.com", 
+        {
+            Id = id,
+            FirstName = "Bill",
+            LastName = "Mei",
+            Email = "bill.mei@somewhere.com",
             Phone = "555-555-5555",
         };
 

examples/AspNet/OData/ConventionsODataWebApiExample/Startup.cs

@@ -18,13 +18,13 @@ public void Configuration( IAppBuilder appBuilder )
         configuration.AddApiVersioning(
             options =>
             {
-                    // reporting api versions will return the headers
-                    // "api-supported-versions" and "api-deprecated-versions"
-                    options.ReportApiVersions = true;
+                // reporting api versions will return the headers
+                // "api-supported-versions" and "api-deprecated-versions"
+                options.ReportApiVersions = true;
 
-                    // apply api versions using conventions rather than attributes
-                    options.Conventions.Controller<OrdersController>()
-                                   .HasApiVersion( 1, 0 );
+                // apply api versions using conventions rather than attributes
+                options.Conventions.Controller<OrdersController>()
+                               .HasApiVersion( 1, 0 );
 
                 options.Conventions.Controller<PeopleController>()
                                    .HasApiVersion( 1, 0 )

examples/AspNet/OData/OpenApiODataWebApiExample/Startup.cs

@@ -107,7 +107,7 @@ public void Configuration( IAppBuilder builder )
             {
                 // build a swagger document and endpoint for each discovered API version
                 swagger.MultipleApiVersions(
-                ( apiDescription, version ) => apiDescription.GetGroupName() == version,
+                ( apiDescription, version ) => apiDescription.GroupName == version,
                 info =>
                 {
                     foreach ( var group in apiExplorer.ApiDescriptions )

examples/AspNet/OData/OpenApiODataWebApiExample/SwaggerDefaultValues.cs

@@ -18,7 +18,7 @@ public class SwaggerDefaultValues : IOperationFilter
     /// <param name="apiDescription">The API description being filtered.</param>
     public void Apply( Operation operation, SchemaRegistry schemaRegistry, ApiDescription apiDescription )
     {
-        operation.deprecated |= apiDescription.IsDeprecated();
+        operation.deprecated |= apiDescription.IsDeprecated;
 
         if ( operation.parameters == null )
         {

examples/AspNet/OData/OpenApiODataWebApiExample/V1/OrdersController.cs

@@ -66,7 +66,7 @@ public IHttpActionResult Post( [FromBody] Order order )
     [MapToApiVersion( "1.0" )]
     [ResponseType( typeof( Order ) )]
     [EnableQuery( AllowedQueryOptions = Select )]
-    public SingleResult<Order> MostExpensive() => 
+    public SingleResult<Order> MostExpensive() =>
         SingleResult.Create( new[] { new Order() { Id = 42, Customer = "Bill Mei" } }.AsQueryable() );
 
     /// <summary>

examples/AspNet/OData/OpenApiODataWebApiExample/V1/PeopleController.cs

@@ -51,7 +51,7 @@ public IHttpActionResult Get( int key, ODataQueryOptions<Person> options )
     [MapToApiVersion( "1.0" )]
     [ResponseType( typeof( Person ) )]
     [EnableQuery( AllowedQueryOptions = Select )]
-    public SingleResult<Person> MostExpensive( ODataQueryOptions<Person> options, CancellationToken ct ) => 
+    public SingleResult<Person> MostExpensive( ODataQueryOptions<Person> options, CancellationToken ct ) =>
         SingleResult.Create( new[] { new Person() { Id = 42, FirstName = "Elon", LastName = "Musk" } }.AsQueryable() );
 
     /// <summary>

examples/AspNet/OData/OpenApiODataWebApiExample/V2/OrdersController.cs

@@ -49,7 +49,7 @@ public IQueryable<Order> Get()
     [ODataRoute( "{key}" )]
     [ResponseType( typeof( Order ) )]
     [EnableQuery( AllowedQueryOptions = Select )]
-    public SingleResult<Order> Get( int key ) => 
+    public SingleResult<Order> Get( int key ) =>
         SingleResult.Create( new[] { new Order() { Id = key, Customer = "John Doe" } }.AsQueryable() );
 
     /// <summary>