Fix failing unit tests

Author: Matthias Gessinger

src/Abstractions/src/Asp.Versioning.Abstractions/DeprecationPolicy.cs

@@ -73,6 +73,6 @@ public bool IsEffective( DateTimeOffset? dateTimeOffset )
             return true;
         }
 
-        return date < when;
+        return date <= when;
     }
 }

src/AspNet/WebApi/src/Asp.Versioning.WebApi.ApiExplorer/ApiExplorer/VersionedApiExplorer.cs

@@ -238,13 +238,11 @@ protected virtual ApiDescriptionGroupCollection InitializeApiDescriptions()
         }
 
         var routes = FlattenRoutes( Configuration.Routes ).ToArray();
-        var sunsetPolicyManager = Configuration.GetSunsetPolicyManager();
-        var deprecationPolicyManager = Configuration.GetDeprecationPolicyManager();
 
         foreach ( var apiVersion in FlattenApiVersions( controllerMappings ) )
         {
-            sunsetPolicyManager.TryGetPolicy( apiVersion, out var sunsetPolicy );
-            deprecationPolicyManager.TryGetPolicy( apiVersion, out var deprecationPolicy );
+            SunsetPolicyManager.TryGetPolicy( apiVersion, out var sunsetPolicy );
+            DeprecationPolicyManager.TryGetPolicy( apiVersion, out var deprecationPolicy );
 
             for ( var i = 0; i < routes.Length; i++ )
             {

src/AspNet/WebApi/test/Asp.Versioning.WebApi.Tests/DefaultApiVersionReporterTest.cs

@@ -13,8 +13,8 @@ public class DefaultApiVersionReporterTest
     public void report_should_add_expected_headers()
     {
         // arrange
-        var sunsetDate = DateTimeOffset.Now;
-        var deprecationDate = DateTimeOffset.Now;
+        var sunsetDate = DateTimeOffset.Now.AddDays( 2 );
+        var deprecationDate = DateTimeOffset.Now.AddDays( 1 );
         var reporter = new DefaultApiVersionReporter( new TestSunsetPolicyManager( sunsetDate ), new TestDeprecationPolicyManager( deprecationDate ) );
         var configuration = new HttpConfiguration();
         var request = new HttpRequestMessage();

src/Client/test/Asp.Versioning.Http.Client.Tests/net#.0/ApiVersionHandlerLoggerTTest.cs

@@ -23,8 +23,8 @@ public async Task on_api_deprecated_should_log_message()
         var date = DateTimeOffset.Now;
         var expected = "API version 1.0 for http://tempuri.org has been deprecated since <unspecified> and will " +
                       $"sunset on {date.ToUniversalTime()}. Additional information: " +
-                      "API Policy (en): http://tempuri.org/policy/en, " +
-                      "API Política (es): http://tempuri.org/policy/es";
+                      "[API Policy (en): http://tempuri.org/policy/en, " +
+                      "API Política (es): http://tempuri.org/policy/es]";
 
         response.Headers.Add( "sunset", date.ToString( "r" ) );
         response.Headers.Add( "link", "<policy/en>; rel=\"sunset\"; type=\"text/html\"; title=\"API Policy\"; hreflang=\"en\"" );

src/Common/src/Common/DefaultApiVersionReporter.cs

@@ -104,6 +104,7 @@ public void Report( HttpResponse response, ApiVersionModel apiVersionModel )
 
         if ( deprecationPolicyManager.TryResolvePolicy( name, version, out var deprecationPolicy ) )
         {
+            // Only emit a deprecation header if the deprecation policy becomes effective before the sunset date.
             if ( deprecationPolicy.IsEffective( sunsetDate ) )
             {
                 response.WriteDeprecationPolicy( deprecationPolicy );

src/Common/test/Common.Tests/DeprecationPolicyBuilderTest.cs

@@ -51,7 +51,7 @@ public void link_should_should_return_existing_builder()
     }
 
     [Fact]
-    public void build_should_construct_sunset_policy()
+    public void build_should_construct_deprecation_policy()
     {
         // arrange
         var builder = new DeprecationPolicyBuilder( default, ApiVersion.Default );
@@ -66,6 +66,6 @@ public void build_should_construct_sunset_policy()
         policy.Should().BeEquivalentTo(
             new DeprecationPolicy(
                 new DateTimeOffset( new DateTime( 2022, 2, 1 ) ),
-                new LinkHeaderValue( new Uri( "http://tempuri.org" ), "sunset" ) ) );
+                new LinkHeaderValue( new Uri( "http://tempuri.org" ), "deprecation" ) ) );
     }
 }