Skip to content

No Reflection#1186

Draft
Youssef1313 wants to merge 1 commit into
dotnet:mainfrom
Youssef1313:dev/ygerges/no-refl2
Draft

No Reflection#1186
Youssef1313 wants to merge 1 commit into
dotnet:mainfrom
Youssef1313:dev/ygerges/no-refl2

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@Youssef1313
Copy link
Copy Markdown
Member Author

Youssef1313 commented May 15, 2026

Hi @commonsensesoftware

This branch builds using a locally-built OpenApi assembly from the changes in dotnet/aspnetcore#66692.

The PR above makes three important changes:

  • Allows AddOpenApi to be called with null document name - which means "register only core services"
  • Adds a public IAdditionalOpenApiDocumentNameProvider interface that you can register to provide the document names.
  • Uses AnyKey for most service registration. This is what gives the flexibility of not needing the document names early when building the host, and allows keyed service retrieval to work for any requested document. At that time, we can then validate the document names as the information will be available then.

Can you please double check that everything works correctly with those changes?

Once you confirm that everything works, I'll create a proposal in aspnetcore repo that replaces dotnet/aspnetcore#66408 and review it with the team.

I might as well tweak some stuff in the current shape I have. For example, I would like the proposed public interface to be not only responsible for the "additional" document names, but basically provides all the document names. That means that we can remove GetDocumentNames from IDocumentProvider. This will also clean up part of our code here.

@Youssef1313
Copy link
Copy Markdown
Member Author

Ping @commonsensesoftware.

It would be good if you can test this soon so we have enough time to bring it in for .NET 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant