Skip to content

Commit cdea7e1

Browse files
github-actions[bot]Copilotwtgodbe
authored
[test-quarantine] Quarantine ServerRoutingTest and ServerVirtualizationTest flaky tests (#65964)
* Quarantine ServerRoutingTest and ServerVirtualizationTest flaky tests ServerRoutingTest.NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation failed 18 times in the components-e2e pipeline over the last 30 days. Associated issue: #65960 ServerVirtualizationTest.CanRenderHtmlTable and CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax failed 2 and 4 times respectively in the components-e2e pipeline. Associated issue: #65961 The xUnit QuarantinedTest attribute is not automatically inherited by server-side test subclasses. Adding explicit virtual overrides to apply the quarantine attribute to the server execution variants. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add missing using directive for InternalTesting --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: William Godbe <wigodbe@microsoft.com>
1 parent 1e4711c commit cdea7e1

3 files changed

Lines changed: 16 additions & 3 deletions

File tree

src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
66
using Microsoft.AspNetCore.Components.E2ETest.Tests;
77
using Microsoft.AspNetCore.E2ETesting;
8+
using Microsoft.AspNetCore.InternalTesting;
89
using Xunit.Abstractions;
910

1011
namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests;
@@ -42,6 +43,10 @@ public ServerRoutingTest(BrowserFixture browserFixture, ToggleExecutionModeServe
4243
: base(browserFixture, serverFixture.WithServerExecution(), output)
4344
{
4445
}
46+
47+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/61080")]
48+
public override void NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation()
49+
=> base.NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation();
4550
}
4651

4752
public class ServerCascadingValueTest : CascadingValueTest
@@ -90,6 +95,14 @@ public ServerVirtualizationTest(BrowserFixture browserFixture, ToggleExecutionMo
9095
: base(browserFixture, serverFixture.WithServerExecution(), output)
9196
{
9297
}
98+
99+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/65852")]
100+
public override void CanRenderHtmlTable()
101+
=> base.CanRenderHtmlTable();
102+
103+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/65852")]
104+
public override void CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax()
105+
=> base.CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax();
93106
}
94107

95108
public class ServerDynamicComponentRenderingTest : DynamicComponentRenderingTest

src/Components/test/E2ETest/Tests/RoutingTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ public void NavigationLock_OverlappingNavigationsCancelExistingNavigations_PushS
971971

972972
[Fact]
973973
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/61080")]
974-
public void NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation()
974+
public virtual void NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation()
975975
{
976976
SetUrlViaPushState("/");
977977

src/Components/test/E2ETest/Tests/VirtualizationTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ public async Task ToleratesIncorrectItemSize()
252252

253253
[Fact]
254254
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/65852")]
255-
public void CanRenderHtmlTable()
255+
public virtual void CanRenderHtmlTable()
256256
{
257257
Browser.MountTestComponent<VirtualizationTable>();
258258
var expectedInitialSpacerStyle = "height: 0px; flex-shrink: 0;";
@@ -612,7 +612,7 @@ public void EmptyContentRendered_Async()
612612

613613
[Fact]
614614
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/65852")]
615-
public void CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax()
615+
public virtual void CanElevateEffectiveMaxItemCount_WhenOverscanExceedsMax()
616616
{
617617
Browser.MountTestComponent<VirtualizationLargeOverscan>();
618618
var container = Browser.Exists(By.Id("virtualize-large-overscan"));

0 commit comments

Comments
 (0)