Add 1ES Unofficial pipeline for Components E2E tests#66759
Open
akoeplinger wants to merge 1 commit into
Open
Conversation
Extract shared job template to avoid duplication between the public and internal pipeline definitions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an internal (1ES Unofficial) Azure DevOps pipeline for running the Components E2E test job, and factors the previously inlined job definition into a shared job template so the public and internal pipeline YAML can reuse the same implementation.
Changes:
- Added a shared job template for the Components E2E test run steps/artifact publishing.
- Updated the existing public
components-e2e-tests.ymlpipeline to reference the new shared job template. - Added a new internal
components-e2e-tests-internal.ymlpipeline that extends the 1ES Unofficial pipeline template and runs the shared job.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .azure/pipelines/jobs/components-e2e-test-job.yml | New shared job template containing the Components E2E test build/test steps and artifact publishing. |
| .azure/pipelines/components-e2e-tests.yml | Replaces the inlined job definition with a reference to the shared job template. |
| .azure/pipelines/components-e2e-tests-internal.yml | New internal pipeline extending 1ES Unofficial template and invoking the shared E2E job template. |
Comment on lines
+20
to
+30
| - task: Cache@2 | ||
| displayName: Cache node_modules | ||
| inputs: | ||
| key: '"node_modules" | "node24" | "$(Agent.OS)" | $(Build.SourcesDirectory)/package-lock.json' | ||
| restoreKeys: | | ||
| "node_modules" | "node24" | "$(Agent.OS)" | ||
| path: node_modules | ||
| cacheHitVar: NODE_MODULES_CACHE_HIT | ||
| - script: npm ci | ||
| displayName: NPM install | ||
| condition: ne(variables.NODE_MODULES_CACHE_HIT, 'true') |
Comment on lines
+65
to
+69
| - script: .dotnet/dotnet test ./src/Components/test/E2ETest -c $(BuildConfiguration) --no-build --filter 'Quarantined=true' -p:RunQuarantinedTests=true | ||
| -p:VsTestUseMSBuildOutput=false | ||
| --logger:"trx%3BLogFileName=Microsoft.AspNetCore.Components.E2ETests.trx" | ||
| --logger:"html%3BLogFileName=Microsoft.AspNetCore.Components.E2ETests.html" | ||
| --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(BuildConfiguration)/Quarantined |
Comment on lines
+91
to
+95
| - name: Components_E2E_Logs | ||
| path: artifacts/log/ | ||
| publishOnError: true | ||
| includeForks: true | ||
| - name: Components_E2E_Test_Logs |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract shared job template to avoid duplication between the public and internal pipeline definitions.