Fix warning when using nullable properties in ValidationMessageStore.Add field accessor#66901
Open
BharatRamsf3693 wants to merge 26 commits into
Open
Fix warning when using nullable properties in ValidationMessageStore.Add field accessor#66901BharatRamsf3693 wants to merge 26 commits into
BharatRamsf3693 wants to merge 26 commits into
Conversation
Contributor
|
Thanks for your PR, @BharatRamsf3693. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Author
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
3 tasks
This was referenced Jun 8, 2026
This was referenced Jun 12, 2026
This was referenced Jun 15, 2026
…Add field accessor
…Add field accessor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning when using nullable properties in ValidationMessageStore.Add field accessor
Description
This PR adds fix and test cases to ensure that ValidationMessageStore.Add correctly supports nullable properties when using expression-based field accessors.
Previously, using ValidationMessageStore.Add with a nullable property (for example, string?) could result in compiler nullability warnings due to overload resolution choosing the non-generic Expression<Func> overload, which requires boxing and leads to mismatched nullability expectations.
This change verifies that the generic overload Add(Expression<Func> accessor, ...) is correctly selected, allowing TField to be inferred as a nullable type (e.g., string?). As a result:
Before
After
The added tests cover:
Fixes #41338