Skip to content

Revert "Skip .NET SDK first-run experience in Helix work items"#67241

Merged
Youssef1313 merged 1 commit into
mainfrom
revert-66916-wtgodbe/skip-first-run-experience
Jun 17, 2026
Merged

Revert "Skip .NET SDK first-run experience in Helix work items"#67241
Youssef1313 merged 1 commit into
mainfrom
revert-66916-wtgodbe/skip-first-run-experience

Conversation

@Youssef1313

Copy link
Copy Markdown
Member

Reverts #66916

Fixes #66925

Copilot AI review requested due to automatic review settings June 16, 2026 15:58
@Youssef1313 Youssef1313 requested review from a team and wtgodbe as code owners June 16, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the earlier change that disabled parts of the .NET SDK first-run experience in Helix work items, returning the Helix test runner and scripts to their prior environment-variable configuration (per #66925, once the underlying SDK issue is resolved).

Changes:

  • Remove DOTNET_NOLOGO and DOTNET_GENERATE_ASPNET_CERTIFICATE from the HelixTestRunner environment setup.
  • Remove the same environment-variable exports/sets from the Helix runtests.sh and runtests.cmd scripts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/tools/HelixTestRunner/TestRunner.cs Reverts adding env vars that suppressed the CLI banner and skipped ASP.NET dev cert generation.
eng/helix/content/runtests.sh Reverts exporting DOTNET_NOLOGO and DOTNET_GENERATE_ASPNET_CERTIFICATE for Helix bash runs.
eng/helix/content/runtests.cmd Reverts setting DOTNET_NOLOGO and DOTNET_GENERATE_ASPNET_CERTIFICATE for Helix Windows runs.

@Youssef1313

Copy link
Copy Markdown
Member Author

Let's re-run CI multiple times to see if we see any hangs before merging this.

@Youssef1313

Copy link
Copy Markdown
Member Author

Helix got green, no hangs, on first attempt.

@Youssef1313

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe wtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Youssef1313

Copy link
Copy Markdown
Member Author

Helix didn't hang the second run, there is an unrelated flaky test failing:

2026-06-16T18:04:31.2796250Z [xUnit.net 00:00:01.16]     Microsoft.AspNetCore.Components.ComponentsMetricsTest.FailParametersSync_RecordsErrorMetric [FAIL]
2026-06-16T18:04:31.2797790Z [xUnit.net 00:00:01.16]       Assert.True() Failure
2026-06-16T18:04:31.2798210Z [xUnit.net 00:00:01.16]       Expected: True
2026-06-16T18:04:31.2798790Z [xUnit.net 00:00:01.16]       Actual:   False
2026-06-16T18:04:31.2799290Z [xUnit.net 00:00:01.16]       Stack Trace:
2026-06-16T18:04:31.2801960Z [xUnit.net 00:00:01.16]         /_/src/Components/Components/test/ComponentsMetricsTest.cs(221,0): at Microsoft.AspNetCore.Components.ComponentsMetricsTest.FailParametersSync_RecordsErrorMetric()
2026-06-16T18:04:31.2802470Z [xUnit.net 00:00:01.16]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
2026-06-16T18:04:31.2803040Z [xUnit.net 00:00:01.16]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
2026-06-16T18:04:31.2859390Z   Failed Microsoft.AspNetCore.Components.ComponentsMetricsTest.FailParametersSync_RecordsErrorMetric [< 1 ms]
2026-06-16T18:04:31.2859600Z   Error Message:
2026-06-16T18:04:31.2859620Z    Assert.True() Failure
2026-06-16T18:04:31.2859630Z Expected: True
2026-06-16T18:04:31.2859660Z Actual:   False
2026-06-16T18:04:31.2859670Z   Stack Trace:
2026-06-16T18:04:31.2859730Z      at Microsoft.AspNetCore.Components.ComponentsMetricsTest.FailParametersSync_RecordsErrorMetric() in /_/src/Components/Components/test/ComponentsMetricsTest.cs:line 221
2026-06-16T18:04:31.2859750Z    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
2026-06-16T18:04:31.2859760Z    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@Youssef1313

Copy link
Copy Markdown
Member Author

I think it should be safe to merge. In case we observed hangs later we can always revisit and revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert https://github.com/dotnet/aspnetcore/pull/66916 once root cause is fixed

3 participants