Revert "Skip .NET SDK first-run experience in Helix work items"#67241
Merged
Conversation
This reverts commit c9a4439.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that disabled parts of the .NET SDK first-run experience in Helix work items, returning the Helix test runner and scripts to their prior environment-variable configuration (per #66925, once the underlying SDK issue is resolved).
Changes:
- Remove
DOTNET_NOLOGOandDOTNET_GENERATE_ASPNET_CERTIFICATEfrom the HelixTestRunner environment setup. - Remove the same environment-variable exports/sets from the Helix
runtests.shandruntests.cmdscripts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/tools/HelixTestRunner/TestRunner.cs | Reverts adding env vars that suppressed the CLI banner and skipped ASP.NET dev cert generation. |
| eng/helix/content/runtests.sh | Reverts exporting DOTNET_NOLOGO and DOTNET_GENERATE_ASPNET_CERTIFICATE for Helix bash runs. |
| eng/helix/content/runtests.cmd | Reverts setting DOTNET_NOLOGO and DOTNET_GENERATE_ASPNET_CERTIFICATE for Helix Windows runs. |
Member
Author
|
Let's re-run CI multiple times to see if we see any hangs before merging this. |
Member
Author
|
Helix got green, no hangs, on first attempt. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
Helix didn't hang the second run, there is an unrelated flaky test failing: |
Member
Author
|
I think it should be safe to merge. In case we observed hangs later we can always revisit and revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #66916
Fixes #66925