Skip to content

GetCompletions should check exit code of invoked application #2137

@tmds

Description

@tmds

This code should probably check the exit code and not consider standard output to be completions when it is non-zero:

if (readToEndTask.Wait(timeout))
{
result = readToEndTask.Result;
}

cc @jonsequitur @adamsitnik

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CompletionsRelated to support for tab completionbugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions