-
Notifications
You must be signed in to change notification settings - Fork 97
[Version 9.0] Feature support for native sized integers (nint, and nuint)
#1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BillWagner
wants to merge
27
commits into
draft-v9
Choose a base branch
from
v9-native-sized-integers
base: draft-v9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6a73647
Add support for native-sized integers
RexJaeschke ebe614d
missing back tick
BillWagner 563f374
Add entry for nint/nuint
RexJaeschke 9d19d32
Apply suggestions from code review
RexJaeschke 3e10994
Apply suggestions from code review
RexJaeschke 1bfce0b
address open comments.
BillWagner 1b49905
Address current comments.
BillWagner 49797ad
Edit pass on `nint`
BillWagner 56cc6f8
Apply suggestions from code review
BillWagner 4e64371
respond to first round feedback.
BillWagner 1bcaf04
Rework Types.md for nint
BillWagner 4d9ae4a
Add predefined operators
BillWagner 7d80804
Further edits.
BillWagner 74f0613
one more edit
BillWagner b647425
Apply suggestions from code review
BillWagner afe0a7c
Update standard/conversions.md
BillWagner e4352ce
lint
BillWagner cfb9cac
Apply suggestions from code review
BillWagner 004ded7
Apply suggestion from @Nigel-Ecma
BillWagner b14f438
remove extra note.
BillWagner a517663
Address operator feedback
BillWagner 755c835
Add additional promotions
BillWagner 586d0d1
Constant expression fix
BillWagner 53705cb
misc formatting fixes
BillWagner fd15588
remove redundant conversions
BillWagner d7f8c8a
em-dashes to hyphen-minus
BillWagner 58b7404
Update RightShift stderr reference for nint/nuint keywords
BillWagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason to have listed
intanduintin the first place? They fall under "can be implicitly converted tolong/ulong."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completeness for one. And, to make it clear that in those cases, no conversion is required.