Skip to content

Removes unnecessary language model dependency in LanguageModelFailurePlugin #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 2 commits into from
Jul 11, 2025
Merged

Removes unnecessary language model dependency in LanguageModelFailurePlugin #1322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c3e62
Removes unnecessary language model dependency in LanguageModelFailure…
waldekmastykarz Jul 11, 2025
d5b2cfb
Merge branch 'main' into fix-languagemodelfailure
waldekmastykarz Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions DevProxy.Plugins/Behavior/LanguageModelFailurePlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ public sealed class LanguageModelFailurePlugin(
ILogger<LanguageModelFailurePlugin> logger,
ISet<UrlToWatch> urlsToWatch,
IProxyConfiguration proxyConfiguration,
IConfigurationSection pluginConfigurationSection,
ILanguageModelClient languageModelClient) :
IConfigurationSection pluginConfigurationSection) :
BasePlugin<LanguageModelFailureConfiguration>(
httpClient,
logger,
Expand Down Expand Up @@ -48,18 +47,6 @@ public sealed class LanguageModelFailurePlugin(

public override string Name => nameof(LanguageModelFailurePlugin);

public override async Task InitializeAsync(InitArgs e, CancellationToken cancellationToken)
{
await base.InitializeAsync(e, cancellationToken);

Logger.LogInformation("Checking language model availability...");
if (!await languageModelClient.IsEnabledAsync(cancellationToken))
{
Logger.LogError("Local language model is not enabled. The {Plugin} will not be used.", Name);
Enabled = false;
}
}

public override async Task BeforeRequestAsync(ProxyRequestArgs e, CancellationToken cancellationToken)
{
Logger.LogTrace("{Method} called", nameof(BeforeRequestAsync));
Expand Down