Reduce GitHub PAT rotation interval from 60 to 30 days#6577
Merged
Conversation
The previous 60-day rotation interval left only a 30-day buffer before the 90-day PAT expiration on GitHub. If manual rotations or timing drift caused mismatches between the KeyVault next-rotation-on tag and the actual PAT expiry, builds would fail unexpectedly. Reducing to 30 days provides a 60-day buffer, making it much less likely that a PAT expires before secret-manager triggers rotation. Fixes: https://dev.azure.com/dnceng/internal/_workitems/edit/9752 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
haruna99
approved these changes
May 21, 2026
wfurt
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces the _nextRotationOnDeltaDays from 60 to 30 days for GitHub PAT secrets.
Problem
The previous 60-day rotation interval left only a 30-day buffer before the 90-day PAT expiration on GitHub. If manual rotations or timing drift caused mismatches between the KeyVault
ext-rotation-on\ tag and the actual PAT expiry, builds would fail unexpectedly (as seen with BotAccount-dotnet-bot-repo-PAT).
Fix
By rotating every 30 days instead of 60, we get a 60-day buffer before expiry, making it much less likely that a PAT expires before secret-manager triggers rotation.
Related