chore: Apply code formatting rules (IDE0028, and IDE0300-IDE0304) (#10458)

chore: apply code formatter for IDE0028, and IDE0300-IDE0304

Author: filzrev

.editorconfig

@@ -78,7 +78,8 @@ csharp_prefer_static_local_function = true:suggestion
 dotnet_diagnostic.IDE0010.severity = suggestion                                    # IDE0010: Add missing cases to switch statement
 dotnet_style_object_initializer = true:suggestion                                  # IDE0017: Use object initializers
 csharp_style_inlined_variable_declaration = true:suggestion                        # IDE0018: Inline variable declaration
-dotnet_style_collection_initializer = true:suggestion                              # IDE0028: Use collection initializers
+dotnet_style_collection_initializer = true:suggestion                              # IDE0028: Use collection initializers or expressions
+dotnet_style_prefer_collection_expression = true:suggestion                        # IDE0028: Use collection initializers or expressions
 dotnet_style_prefer_auto_properties = true:suggestion                              # IDE0032: Use auto-implemented property
 dotnet_style_explicit_tuple_names = true:suggestion                                # IDE0033: Use explicitly provided tuple name
 csharp_prefer_simple_default_expression = true:suggestion                          # IDE0034: Simplify default expression

src/Docfx.App/Config/BuildJsonConfig.cs

@@ -72,7 +72,7 @@ internal class BuildJsonConfig
     /// </summary>
     [JsonProperty("globalMetadataFiles")]
     [JsonPropertyName("globalMetadataFiles")]
-    public ListWithStringFallback GlobalMetadataFiles { get; set; } = new();
+    public ListWithStringFallback GlobalMetadataFiles { get; set; } = [];
 
     /// <summary>
     /// Metadata that applies to some specific files.
@@ -99,7 +99,7 @@ internal class BuildJsonConfig
     /// </summary>
     [JsonProperty("template")]
     [JsonPropertyName("template")]
-    public ListWithStringFallback Template { get; set; } = new();
+    public ListWithStringFallback Template { get; set; } = [];
 
     /// <summary>
     /// The themes applied to the documentation.
@@ -123,7 +123,7 @@ internal class BuildJsonConfig
     ///  </example>
     [JsonProperty("postProcessors")]
     [JsonPropertyName("postProcessors")]
-    public ListWithStringFallback PostProcessors { get; set; } = new();
+    public ListWithStringFallback PostProcessors { get; set; } = [];
 
     /// <summary>
     /// Run in debug mode. With debug mode, raw model and view model will be exported

src/Docfx.App/Config/FileMetadataPairs.cs

@@ -39,7 +39,7 @@ public FileMetadataPairs(IEnumerable<FileMetadataPairsItem> items)
     /// </summary>
     public FileMetadataPairs(FileMetadataPairsItem item)
     {
-        _items = new List<FileMetadataPairsItem> { item };
+        _items = [item];
     }
 
     /// <summary>

src/Docfx.App/Config/GroupConfig.cs

@@ -23,5 +23,5 @@ internal class GroupConfig
     /// </summary>
     [Newtonsoft.Json.JsonExtensionData]
     [System.Text.Json.Serialization.JsonExtensionData]
-    public Dictionary<string, object> Metadata { get; set; } = new();
+    public Dictionary<string, object> Metadata { get; set; } = [];
 }

src/Docfx.App/Helpers/DocumentBuilderWrapper.cs

@@ -263,7 +263,7 @@ private static FileMetadata GetFileMetadata(string baseDirectory, BuildJsonConfi
         {
             foreach (var (key, value) in config.FileMetadata)
             {
-                var list = result.TryGetValue(key, out var items) ? items : result[key] = new();
+                var list = result.TryGetValue(key, out var items) ? items : result[key] = [];
                 foreach (var pair in value.Items)
                 {
                     list.Add(new FileMetadataItem(pair.Glob, key, pair.Value));
@@ -277,7 +277,7 @@ private static FileMetadata GetFileMetadata(string baseDirectory, BuildJsonConfi
             {
                 foreach (var (key, value) in JsonUtility.Deserialize<Dictionary<string, FileMetadataPairs>>(path))
                 {
-                    var list = result.TryGetValue(key, out var items) ? items : result[key] = new();
+                    var list = result.TryGetValue(key, out var items) ? items : result[key] = [];
                     foreach (var pair in value.Items)
                     {
                         list.Add(new FileMetadataItem(pair.Glob, key, pair.Value));

src/Docfx.App/Helpers/MetadataMerger.cs

@@ -14,8 +14,8 @@ namespace Docfx;
 
 internal class MetadataMerger
 {
-    private readonly Dictionary<string, Dictionary<string, object>> _metaTable = new();
-    private readonly Dictionary<string, Dictionary<string, object>> _propTable = new();
+    private readonly Dictionary<string, Dictionary<string, object>> _metaTable = [];
+    private readonly Dictionary<string, Dictionary<string, object>> _propTable = [];
 
     public void Merge(MetadataMergeParameters parameters)
     {

src/Docfx.App/PdfBuilder.cs

@@ -311,7 +311,7 @@ await Parallel.ForEachAsync(pages, async (item, _) =>
 
             var key = CleanUrl(url);
             if (!pagesByUrl.TryGetValue(key, out var dests))
-                pagesByUrl[key] = dests = new();
+                pagesByUrl[key] = dests = [];
             dests.Add((node, document.Structure.Catalog.GetNamedDestinations()));
 
             pageBytes[node] = bytes;

src/Docfx.App/RunBuild.cs

@@ -21,7 +21,7 @@ public static string Exec(BuildJsonConfig config, BuildOptions options, string c
         var stopwatch = Stopwatch.StartNew();
         if (config.Template == null || config.Template.Count == 0)
         {
-            config.Template = new ListWithStringFallback { "default" };
+            config.Template = ["default"];
         }
 
         var baseDirectory = Path.GetFullPath(string.IsNullOrEmpty(configDirectory) ? Directory.GetCurrentDirectory() : configDirectory);

src/Docfx.App/RunMerge.cs

@@ -56,7 +56,7 @@ private static MetadataMergeParameters ConfigToParameter(MergeJsonItemConfig con
             OutputBaseDir = outputDirectory,
             Metadata = config.GlobalMetadata?.ToImmutableDictionary() ?? ImmutableDictionary<string, object>.Empty,
             FileMetadata = ConvertToFileMetadataItem(baseDirectory, config.FileMetadata),
-            TocMetadata = config.TocMetadata?.ToImmutableList() ?? ImmutableList<string>.Empty,
+            TocMetadata = config.TocMetadata?.ToImmutableList() ?? [],
             Files = GetFileCollectionFromFileMapping(
                 baseDirectory,
                 DocumentType.Article,

src/Docfx.Build.Common/MarkdownReader.cs

@@ -13,7 +13,7 @@ namespace Docfx.Build.Common;
 
 public class MarkdownReader
 {
-    private static readonly ImmutableList<string> RequiredProperties = ImmutableList.Create(Constants.PropertyName.Uid);
+    private static readonly ImmutableList<string> RequiredProperties = [Constants.PropertyName.Uid];
 
     public static IEnumerable<OverwriteDocumentModel> ReadMarkdownAsOverwrite(IHostService host, FileAndType ft)
     {