Add warning to only load trusted models#53999
Open
svick wants to merge 1 commit into
Open
Conversation
svick
requested review from
a team,
JakeRadMSFT,
gewarren and
luisquintanilla
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a security warning to the ML.NET “save and load trained models” guide to remind readers to load model files only from trusted sources.
Changes:
- Adds an
[!IMPORTANT]admonition under “Load a model stored locally” warning about the security risks of loading untrusted models.
Comment on lines
+94
to
+96
| > [!IMPORTANT] | ||
| > | ||
| > Only load models from trusted sources. Loading models from untrusted sources is a security risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ML.NET assumes that loaded models are trusted. We should explicitly document this assumption and warn users not to load untrusted models.
Companion PR to change API docs: dotnet/machinelearning#7611
Internal previews