Refactor buffer examples to improve safety#54669
Open
AaronRobinsonMSFT wants to merge 1 commit into
Open
Conversation
Updated examples to use classes instead of structs for buffer management and added InlineArrayAttribute for safe buffer usage.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the fixed-size buffer examples in customize-struct-marshalling.md to improve safety guidance around StructLayoutAttribute.Size and to steer readers toward InlineArrayAttribute.
Changes:
- Renamed the “unsafe” and “safe” example types.
- Moved the
InlineArraybuffer type into a nested type inside the safe example. - Switched the examples from
structtoclass(as currently written in the diff).
Show a summary per file
| File | Description |
|---|---|
| docs/standard/native-interop/customize-struct-marshalling.md | Updates the fixed-size buffer examples intended to demonstrate unsafe StructLayoutAttribute.Size usage and the safer InlineArrayAttribute alternative. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
gewarren
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed feedback from #50898
Internal previews