numeric type mismatch

[DickBaker]

Type of issue

Other (describe below)

Description

C# code example defines
enum SingleHue : short
enum MultipleHue : short

but the loop variable is of type int. AFAIK the compiler/JIT will have to enlarge before any bit operation and that is a perf no-no
no advantage reason given why code should be based on short, so I suggest you either use matching int (or better just omit and let compiler choose)

BTW this code shows all of C#, F# and VB language examples, whereas imho devs are likely to focus on just ONE.
Elsewhere in the docs the UX offers a combo to display lang of choice (to reduce clutter and brain-fade). TIA !

Page URL

https://learn.microsoft.com/en-us/dotnet/api/system.flagsattribute.-ctor?view=net-10.0&devlangs=csharp&f1url=%3FappId%3DDev18IDEF1%26l%3DEN-US%26k%3Dk%28System.FlagsAttribute.%23ctor%29%3Bk%28DevLang-csharp%29%26rd%3Dtrue

Content source URL

https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System/FlagsAttribute.xml

Document Version Independent Id

4c34e6ce-3163-99f4-3d05-251583b8a874

Platform Id

83a0548e-26e2-3231-958d-bfbb757475a1

Article author

@dotnet-bot

---

Associated WorkItem - 572082

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime

[tannergooding]

but the loop variable is of type int.

This doesn't matter, int is the most common/core type and it is common to use it alongside smaller types.

AFAIK the compiler/JIT will have to enlarge before any bit operation and that is a perf no-no

This also doesn't matter, such widening operations are typically free on any hardware from the past 25 years. It is absolutely not a "perf no-no" and is a common thing in many perf critical scenarios, especially for string data (which is typically 1 or 2-bytes per character).

no advantage reason given why code should be based on short, so I suggest you either use matching int

It is a piece of example code and simply showcases that [Flags] works on many types of enums

(or better just omit and let compiler choose)

The compiler doesn't choose, it is int unless explicitly changed to another type

[tannergooding]

BTW this code shows all of C#, F# and VB language examples, whereas imho devs are likely to focus on just ONE.
Elsewhere in the docs the UX offers a combo to display lang of choice (to reduce clutter and brain-fade). TIA !

This one feels like it should actually be fixed and is inconsistent. CC. @gewarren

[gewarren]

BTW this code shows all of C#, F# and VB language examples, whereas imho devs are likely to focus on just ONE.
Elsewhere in the docs the UX offers a combo to display lang of choice (to reduce clutter and brain-fade). TIA !

This one feels like it should actually be fixed and is inconsistent. CC. @gewarren

I believe the reason all the code languages are shown is because there's no F# definition for the constructor, and therefore F# doesn't appear in the language picker dropdown. I'll investigate further (internal link)...