Skip to content

Clean up exceptions#12777

Merged
gewarren merged 3 commits into
dotnet:mainfrom
gewarren:cleanup-062326
Jun 24, 2026
Merged

Clean up exceptions#12777
gewarren merged 3 commits into
dotnet:mainfrom
gewarren:cleanup-062326

Conversation

@gewarren

Copy link
Copy Markdown
Collaborator
  • Remove exceptions for Compact Framework
  • Remove exceptions for old Windows versions
  • Remove other exceptions when NSE is always thrown

Contributes to #12513.

Copilot AI review requested due to automatic review settings June 23, 2026 22:13
@gewarren gewarren requested review from a team as code owners June 23, 2026 22:13
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the cleanup work for #12513 by removing .NET Compact Framework and legacy Windows-version-specific exception documentation from the ECMA XML reference docs, and by simplifying a few exception descriptions now that those platform distinctions aren’t relevant for modern .NET.

Changes:

  • Removed .NET Compact Framework–specific NotSupportedException / ObjectDisposedException entries from several networking and reflection APIs.
  • Removed legacy Windows-version-specific exception conditions (for example, Windows XP/CE notes) and simplified some multi-clause exception descriptions.
  • Reformatted parts of FileSystemWatcher remarks content (table + NOTE blocks) to be cleaner markdown.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xml/System/Type.xml Removes .NET Compact Framework exception notes from Type member docs.
xml/System.Net/HttpWebRequest.xml Removes Compact Framework–specific ObjectDisposedException entries from request stream APIs.
xml/System.Net.Sockets/TcpClient.xml Simplifies ReceiveBufferSize exception text by removing Compact Framework-specific content.
xml/System.Net.Sockets/Socket.xml Simplifies GetSocketOption exception text by removing Compact Framework-specific content.
xml/System.IO/FileSystemWatcher.xml Removes legacy Windows remote-watching remarks and cleans up markdown formatting (table/callouts).
xml/System.IO/FileSystemInfo.xml Removes legacy Windows XP-specific IOException wording for Delete().
xml/System.IO/FileInfo.xml Removes legacy Windows XP-specific IOException wording for Delete().
xml/System.IO/File.xml Simplifies IOException documentation for File.Delete.
xml/System.IO/DirectoryInfo.xml Removes legacy Windows XP-specific handle-related exception wording from Delete() overloads.
xml/System.IO/Directory.xml Removes Windows CE / Compact Framework NotSupportedException documentation.
xml/System.IO.Ports/SerialPort.xml Removes Compact Framework-specific async model exception note.
xml/System.Data.Common/DbDataReader.xml Removes exceptions that conflict with the current “NotSupportedException” statement for GetSchemaTable().

Comment thread xml/System.Data.Common/DbDataReader.xml Outdated
Comment thread xml/System.IO/FileInfo.xml
Comment thread xml/System.IO/FileSystemInfo.xml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit 998f510 into dotnet:main Jun 24, 2026
6 checks passed
@gewarren gewarren deleted the cleanup-062326 branch June 24, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants