Clean up exceptions#12777
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the cleanup work for #12513 by removing .NET Compact Framework and legacy Windows-version-specific exception documentation from the ECMA XML reference docs, and by simplifying a few exception descriptions now that those platform distinctions aren’t relevant for modern .NET.
Changes:
- Removed .NET Compact Framework–specific
NotSupportedException/ObjectDisposedExceptionentries from several networking and reflection APIs. - Removed legacy Windows-version-specific exception conditions (for example, Windows XP/CE notes) and simplified some multi-clause exception descriptions.
- Reformatted parts of
FileSystemWatcherremarks content (table + NOTE blocks) to be cleaner markdown.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System/Type.xml | Removes .NET Compact Framework exception notes from Type member docs. |
| xml/System.Net/HttpWebRequest.xml | Removes Compact Framework–specific ObjectDisposedException entries from request stream APIs. |
| xml/System.Net.Sockets/TcpClient.xml | Simplifies ReceiveBufferSize exception text by removing Compact Framework-specific content. |
| xml/System.Net.Sockets/Socket.xml | Simplifies GetSocketOption exception text by removing Compact Framework-specific content. |
| xml/System.IO/FileSystemWatcher.xml | Removes legacy Windows remote-watching remarks and cleans up markdown formatting (table/callouts). |
| xml/System.IO/FileSystemInfo.xml | Removes legacy Windows XP-specific IOException wording for Delete(). |
| xml/System.IO/FileInfo.xml | Removes legacy Windows XP-specific IOException wording for Delete(). |
| xml/System.IO/File.xml | Simplifies IOException documentation for File.Delete. |
| xml/System.IO/DirectoryInfo.xml | Removes legacy Windows XP-specific handle-related exception wording from Delete() overloads. |
| xml/System.IO/Directory.xml | Removes Windows CE / Compact Framework NotSupportedException documentation. |
| xml/System.IO.Ports/SerialPort.xml | Removes Compact Framework-specific async model exception note. |
| xml/System.Data.Common/DbDataReader.xml | Removes exceptions that conflict with the current “NotSupportedException” statement for GetSchemaTable(). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #12513.