Skip to content

Commit 4b9de87

Browse files
authored
Remove DOTNET_ROLL_FORWARD environment variable from .NET 10 and 11 SDK images (#7256)
1 parent 73e40ba commit 4b9de87

63 files changed

Lines changed: 121 additions & 201 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

eng/dockerfile-templates/sdk/Dockerfile.envs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
VARIABLES[cat("sdk|", dotnetVersion, "|build-version")])) ^
1818
set isAlpine to find(OS_VERSION, "alpine") >= 0 ^
1919
set isWindows to find(OS_VERSION, "nanoserver") >= 0 || find(OS_VERSION, "windowsservercore") >= 0 ^
20-
set lineContinuation to when(isWindows, "`", "\") ^
21-
22-
set includePowerShellRollForward to dotnetVersion != "8.0" && dotnetVersion != "9.0"
20+
set lineContinuation to when(isWindows, "`", "\")
2321
}}ENV {{lineContinuation}}
2422
# Do not generate certificate
2523
DOTNET_GENERATE_ASPNET_CERTIFICATE=false {{lineContinuation}}
@@ -34,6 +32,4 @@
3432
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3533
NUGET_XMLDOC_MODE=skip {{if ARGS["include-powershell-vars"]:{{lineContinuation}}
3634
# PowerShell telemetry for docker image usage
37-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-{{OS_ARCH_HYPHENATED}}{{if includePowerShellRollForward: {{lineContinuation}}
38-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
39-
DOTNET_ROLL_FORWARD=Major}}}}
35+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-{{OS_ARCH_HYPHENATED}}}}

src/sdk/10.0/alpine3.23/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ ENV \
3232
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3333
NUGET_XMLDOC_MODE=skip \
3434
# PowerShell telemetry for docker image usage
35-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Alpine-3.23 \
36-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
37-
DOTNET_ROLL_FORWARD=Major
35+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Alpine-3.23
3836

3937
RUN apk add --upgrade --no-cache \
4038
curl \

src/sdk/10.0/alpine3.24/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ ENV \
3232
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3333
NUGET_XMLDOC_MODE=skip \
3434
# PowerShell telemetry for docker image usage
35-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Alpine-3.24 \
36-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
37-
DOTNET_ROLL_FORWARD=Major
35+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Alpine-3.24
3836

3937
RUN apk add --upgrade --no-cache \
4038
curl \

src/sdk/10.0/azurelinux3.0/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ ENV \
3434
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3535
NUGET_XMLDOC_MODE=skip \
3636
# PowerShell telemetry for docker image usage
37-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-3.0 \
38-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
39-
DOTNET_ROLL_FORWARD=Major
37+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-3.0
4038

4139
RUN tdnf install -y \
4240
git \

src/sdk/10.0/azurelinux3.0/arm64v8/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ ENV \
3434
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3535
NUGET_XMLDOC_MODE=skip \
3636
# PowerShell telemetry for docker image usage
37-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-3.0-arm64 \
38-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
39-
DOTNET_ROLL_FORWARD=Major
37+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-3.0-arm64
4038

4139
RUN tdnf install -y \
4240
git \

src/sdk/10.0/azurelinux4.0/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ENV \
3535
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3636
NUGET_XMLDOC_MODE=skip \
3737
# PowerShell telemetry for docker image usage
38-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-4.0 \
39-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
40-
DOTNET_ROLL_FORWARD=Major
38+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-4.0
4139

4240
RUN dnf install -y \
4341
git \

src/sdk/10.0/azurelinux4.0/arm64v8/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ENV \
3535
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3636
NUGET_XMLDOC_MODE=skip \
3737
# PowerShell telemetry for docker image usage
38-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-4.0-arm64 \
39-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
40-
DOTNET_ROLL_FORWARD=Major
38+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Azure-Linux-4.0-arm64
4139

4240
RUN dnf install -y \
4341
git \

src/sdk/10.0/nanoserver-ltsc2022/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ ENV `
7878
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
7979
NUGET_XMLDOC_MODE=skip `
8080
# PowerShell telemetry for docker image usage
81-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-NanoServer-ltsc2022 `
82-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
83-
DOTNET_ROLL_FORWARD=Major
81+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-NanoServer-ltsc2022
8482

8583
# In order to set system PATH, ContainerAdministrator must be used
8684
USER ContainerAdministrator

src/sdk/10.0/nanoserver-ltsc2025/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ ENV `
7878
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
7979
NUGET_XMLDOC_MODE=skip `
8080
# PowerShell telemetry for docker image usage
81-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-NanoServer-ltsc2025 `
82-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
83-
DOTNET_ROLL_FORWARD=Major
81+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-NanoServer-ltsc2025
8482

8583
# In order to set system PATH, ContainerAdministrator must be used
8684
USER ContainerAdministrator

src/sdk/10.0/noble/amd64/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ ENV \
3030
# Skip extraction of XML docs - generally not useful within an image/container - helps performance
3131
NUGET_XMLDOC_MODE=skip \
3232
# PowerShell telemetry for docker image usage
33-
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Ubuntu-24.04 \
34-
# Workaround for https://github.com/PowerShell/PowerShell/issues/20685
35-
DOTNET_ROLL_FORWARD=Major
33+
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetSDK-Ubuntu-24.04
3634

3735
RUN apt-get update \
3836
&& apt-get install -y --no-install-recommends \

0 commit comments

Comments
 (0)