Skip to content

Commit cd2a5a9

Browse files
committed
Update comments in BuildUpdaterService
1 parent 036e7a0 commit cd2a5a9

1 file changed

Lines changed: 14 additions & 1 deletion

File tree

eng/update-dependencies/BuildUpdaterService.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,18 @@ internal class BuildUpdaterService(
2525
private readonly IBasicBarClient _barClient = barClient;
2626
private readonly ILogger<BuildUpdaterService> _logger = logger;
2727

28+
/// <summary>
29+
/// Updates product versions according to a specific BAR build of the VMR. This will update the
30+
/// manifest.versions.json file, generate Dockerfiles and Readmes from the templates, and if
31+
/// credentials are provided, submit a pull request.
32+
/// </summary>
33+
/// <param name="build">
34+
/// A build of the VMR repo (dotnet/dotnet)
35+
/// </param>
36+
/// <param name="pullRequestOptions">
37+
/// Options for creating a pull request. If credentials are provided, a pull request will be created.
38+
/// </param>
39+
/// <returns>Exit code (0 for success)</returns>
2840
public async Task<int> UpdateFrom(Build build, CreatePullRequestOptions pullRequestOptions)
2941
{
3042
_logger.LogInformation("Updating to build {build.Id} with commit {options.Repo}@{build.Commit}",
@@ -54,7 +66,8 @@ public async Task<int> UpdateFrom(Build build, CreatePullRequestOptions pullRequ
5466
DockerfileVersion = dockerfileVersion.ToString(),
5567
ProductVersions = new Dictionary<string, string?>()
5668
{
57-
// In the VMR, runtime and aspnetcore versions are coupled
69+
// "dotnet" version is also required. It sets the "dotnet|*|product-version"
70+
// variable which is used for runtime-deps, runtime, and aspnet tags.
5871
{ "dotnet", productCommits.Runtime.Version },
5972
{ "runtime", productCommits.Runtime.Version },
6073
{ "aspnet", productCommits.AspNetCore.Version },

0 commit comments

Comments
 (0)