Skip to content

Commit d1bf85d

Browse files
authored
Revert "Workaround issue where Update Dependencies tool would sometimes overwrite PRs (#6456)" (#6465)
1 parent 9bdf019 commit d1bf85d

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

eng/update-dependencies/SpecificCommand.cs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,6 @@ private static async Task CreateGitHubPullRequest(string commitMessage, PullRequ
233233
if (pullRequestToUpdate == null || pullRequestToUpdate.Head.Ref != $"{upstreamBranch.Name}-{branchSuffix}")
234234
{
235235
Trace.WriteLine("Didn't find a PR to update. Submitting a new one.");
236-
237-
// Workaround for https://github.com/dotnet/dotnet-docker/issues/6427
238-
//
239-
// CreateOrUpdateAsync has its own internal logic to search for and update PRs, and it doesn't
240-
// check that source branch names match. It only checks if the author matches the current user.
241-
// If we don't force the creation of a new PR here, then we run the risk of overwriting other
242-
// unrelated PRs. The downside is that since SearchPullRequestsAsync only returns one result, we
243-
// may end up submitting a duplicate PR, but that's still better than overwriting an unrelated PR.
244-
// https://github.com/dotnet/docker-tools/issues/1658 tracks migrating off of this library.
245-
prOptions.ForceCreate = true;
246-
247236
await prCreator.CreateOrUpdateAsync(
248237
commitMessage,
249238
commitMessage,

0 commit comments

Comments
 (0)