Also skip Save_changed_optional_one_to_one_with_alternate_key_in_store

Author: AndriySvyryd

azure-pipelines-internal-tests.yml

@@ -137,7 +137,7 @@ extends:
                   Test__Cosmos__DefaultConnection: $(_CosmosConnectionUrl)
                   Test__SqlServer__DefaultConnection: "Data Source="
                 displayName: Build
-              - script: .dotnet\dotnet test test\EFCore.ApiBaseline.Tests -configuration $(_BuildConfig)
+              - script: .dotnet\dotnet test test\EFCore.ApiBaseline.Tests -p:Configuration=$(_BuildConfig)
                 displayName: Test API Baselines
                 condition: succeeded()
               - powershell: |

azure-pipelines-public.yml

@@ -81,7 +81,7 @@ stages:
                   Test__Cosmos__DefaultConnection: $(_CosmosConnectionUrl)
                   Test__SqlServer__DefaultConnection: "Data Source="
                 name: Build
-              - script: .dotnet\dotnet test test\EFCore.ApiBaseline.Tests -configuration $(_BuildConfig)
+              - script: .dotnet\dotnet test test\EFCore.ApiBaseline.Tests -p:Configuration=$(_BuildConfig)
                 displayName: Test API Baselines
                 condition: succeeded()
               - powershell: |

test/EFCore.InMemory.FunctionalTests/GraphUpdates/ProxyGraphUpdatesInMemoryTest.cs

@@ -10,12 +10,10 @@ public abstract class ProxyGraphUpdatesInMemoryTestBase<TFixture>(TFixture fixtu
         where TFixture : ProxyGraphUpdatesInMemoryTestBase<TFixture>.ProxyGraphUpdatesInMemoryFixtureBase, new()
     {
         // FK constraint checking.
-        [Fact]
         public override Task Optional_one_to_one_relationships_are_one_to_one()
             => Assert.ThrowsAnyAsync<Exception>(() => base.Optional_one_to_one_relationships_are_one_to_one());
 
         // FK constraint checking.
-        [Fact]
         public override Task Optional_one_to_one_with_AK_relationships_are_one_to_one()
             => Assert.ThrowsAnyAsync<Exception>(() => base.Optional_one_to_one_with_AK_relationships_are_one_to_one());
 
@@ -100,12 +98,10 @@ public override Task Required_many_to_one_dependents_with_alternate_key_are_casc
             => Task.CompletedTask;
 
         // FK constraint checking.
-        [Fact]
         public override Task Required_one_to_one_relationships_are_one_to_one()
             => Assert.ThrowsAnyAsync<Exception>(() => base.Required_one_to_one_relationships_are_one_to_one());
 
         // FK constraint checking.
-        [Fact]
         public override Task Required_one_to_one_with_AK_relationships_are_one_to_one()
             => Assert.ThrowsAnyAsync<Exception>(() => base.Required_one_to_one_with_AK_relationships_are_one_to_one());
 
@@ -121,7 +117,7 @@ public override Task Required_many_to_one_dependents_with_alternate_key_are_casc
         public override Task Can_attach_full_optional_graph_of_duplicates()
             => Task.CompletedTask;
 
-        // Cascade delete.
+        // Graph fixup ordering is non-deterministic on InMemory.
         public override Task Can_attach_full_required_AK_graph_of_duplicates()
             => Task.CompletedTask;
 
@@ -141,6 +137,10 @@ public override Task Reparent_required_non_PK_one_to_one_with_alternate_key(
             bool useExistingRoot)
             => Task.CompletedTask;
 
+        // Cascade delete.
+        public override Task Save_changed_optional_one_to_one_with_alternate_key_in_store()
+            => Task.CompletedTask;
+
         // Cascade delete.
         public override Task Sever_required_one_to_one(ChangeMechanism changeMechanism)
             => Task.CompletedTask;
@@ -171,10 +171,17 @@ protected override async Task ExecuteWithStrategyInTransactionAsync(
             Func<DbContext, Task> nestedTestOperation2 = null,
             Func<DbContext, Task> nestedTestOperation3 = null)
         {
-            await base.ExecuteWithStrategyInTransactionAsync(
-                testOperation, nestedTestOperation1, nestedTestOperation2, nestedTestOperation3);
-
-            await Fixture.ReseedAsync();
+            // InMemory has no real transactions, so the shared store is mutated directly by each test and must be
+            // reseeded afterwards.
+            try
+            {
+                await base.ExecuteWithStrategyInTransactionAsync(
+                    testOperation, nestedTestOperation1, nestedTestOperation2, nestedTestOperation3);
+            }
+            finally
+            {
+                await Fixture.ReseedAsync();
+            }
         }
 
         public abstract class ProxyGraphUpdatesInMemoryFixtureBase : ProxyGraphUpdatesFixtureBase

test/EFCore.Specification.Tests/Query/NorthwindAggregateOperatorsQueryTestBase.cs

@@ -249,14 +249,16 @@ public virtual Task Average_over_nested_subquery(bool async)
         => AssertAverage(
             async,
             ss => ss.Set<Customer>().OrderBy(c => c.CustomerID).Take(3),
-            selector: c => (decimal)c.Orders.Average(double (o) => 5 + o.OrderDetails.Average(int (od) => od.ProductID)));
+            selector: c => (decimal)c.Orders.Average(double (o) => 5 + o.OrderDetails.Average(int (od) => od.ProductID)),
+            asserter: (e, a) => Assert.Equal(e, a, 10));
 
     [Theory, MemberData(nameof(IsAsyncData))]
     public virtual Task Average_over_max_subquery(bool async)
         => AssertAverage(
             async,
             ss => ss.Set<Customer>().OrderBy(c => c.CustomerID).Take(3),
-            selector: c => (decimal)c.Orders.Average(int (o) => 5 + o.OrderDetails.Max(int (od) => od.ProductID)));
+            selector: c => (decimal)c.Orders.Average(int (o) => 5 + o.OrderDetails.Max(int (od) => od.ProductID)),
+            asserter: (e, a) => Assert.Equal(e, a, 10));
 
     [Theory, MemberData(nameof(IsAsyncData))]
     public virtual Task Average_on_float_column(bool async)

test/EFCore.SqlServer.FunctionalTests/BuiltInDataTypesSqlServerTest.cs

@@ -3859,8 +3859,8 @@ public async Task Xml_value_round_trips(string value, string expected)
 SELECT COALESCE([x].[Content], @value)
 FROM [XmlTestDocument] AS [x]
 WHERE [x].[Id] = @id
-""",
-            query.ToQueryString());
+""".ReplaceLineEndings(),
+            query.ToQueryString().ReplaceLineEndings());
 
         var roundTripped = await query.SingleAsync();
         Assert.Equal(expected, roundTripped);