Fix SQL Server tests

Author: AndriySvyryd

.agents/skills/cosmos-provider/SKILL.md

@@ -19,4 +19,4 @@ Non-relational provider with its own parallel query pipeline. Uses JSON for docu
 ## Azure Cosmos DB Emulator for Tests
 
 - `TestEnvironment.InitializeAsync()` auto-starts a `Testcontainers.CosmosDb` container when `Test__Cosmos__DefaultConnection` is not set. Set the env var to use an existing emulator instead.
-- Skip tests requiring unsupported features on the Linux emulator with `[CosmosCondition(CosmosCondition.IsNotLinuxEmulator)]`.
+- Skip tests requiring unsupported features on the Linux emulator with ` [ConditionalFact(typeof(CosmosTestEnvironment), nameof(CosmosTestEnvironment.IsNotLinuxEmulator))]`.

eng/Versions.props

@@ -52,6 +52,7 @@
     <OpenTelemetryExporterInMemoryVersion>1.15.1</OpenTelemetryExporterInMemoryVersion>
     <SQLitePCLRawVersion>3.0.3</SQLitePCLRawVersion>
     <SQLite3MCPCLRawBundleVersion>2.3.2</SQLite3MCPCLRawBundleVersion>
+    <XUnitV3Version>4.0.0-pre.81</XUnitV3Version>
     <MicrosoftDotNetXUnitV3ExtensionsVersion>11.0.0-beta.26263.112</MicrosoftDotNetXUnitV3ExtensionsVersion>
     <MicrosoftTestingPlatformVersion>2.2.2</MicrosoftTestingPlatformVersion>
   </PropertyGroup>

src/EFCore/Metadata/Internal/ForeignKey.cs

@@ -951,6 +951,7 @@ public virtual IDependentKeyValueFactory DependentKeyValueFactory
             if (field == null)
             {
                 EnsureReadOnly();
+                ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
             }
 
             return field!;

src/EFCore/Metadata/RuntimeForeignKey.cs

@@ -259,18 +259,25 @@ IEnumerable<IReadOnlySkipNavigation> IReadOnlyForeignKey.GetReferencingSkipNavig
     /// <inheritdoc />
     [DebuggerStepThrough]
     IDependentKeyValueFactory<TKey> IForeignKey.GetDependentKeyValueFactory<TKey>()
-        => (IDependentKeyValueFactory<TKey>)_dependentKeyValueFactory!;
+        => (IDependentKeyValueFactory<TKey>)((IRuntimeForeignKey)this).DependentKeyValueFactory;
 
     /// <inheritdoc />
     [DebuggerStepThrough]
     IDependentKeyValueFactory IForeignKey.GetDependentKeyValueFactory()
-        => _dependentKeyValueFactory!;
+        => ((IRuntimeForeignKey)this).DependentKeyValueFactory;
 
     /// <inheritdoc />
     IDependentKeyValueFactory IRuntimeForeignKey.DependentKeyValueFactory
     {
         [DebuggerStepThrough]
-        get => _dependentKeyValueFactory!;
+        get
+        {
+            if (_dependentKeyValueFactory == null)
+            {
+                ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
+            }
+            return _dependentKeyValueFactory!;
+        }
 
         [DebuggerStepThrough]
         set => _dependentKeyValueFactory = value;

test/Directory.Build.props

@@ -8,8 +8,9 @@
     <NuGetAudit>false</NuGetAudit>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(IsUnitTestProject)' == 'true'">
-    <TestRunnerName>XUnitV3</TestRunnerName>
+  <PropertyGroup Condition="'$(IsTestProject)' != 'false'">
+    <OutputType>Exe</OutputType>
+   <TestRunnerName>XUnitV3</TestRunnerName>
   </PropertyGroup>
 
 </Project>

test/EFCore.AspNet.Specification.Tests/EFCore.AspNet.Specification.Tests.csproj

@@ -8,6 +8,9 @@
     <Nullable>disable</Nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IsPackable>true</IsPackable>
+    <!-- This project contains base tests to be used by providers, but is not itself a test project with
+         tests to be executed. Disable test discovery. -->
+    <IsTestProject>false</IsTestProject>
     <IncludeSymbols>true</IncludeSymbols>
     <ImplicitUsings>true</ImplicitUsings>
     <NoWarn>$(NoWarn);8981</NoWarn>

test/EFCore.Cosmos.FunctionalTests/Query/Translations/VectorSearchTranslationsCosmosTest.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.EntityFrameworkCore.Query.Translations;
 
-[CosmosCondition(CosmosCondition.IsNotLinuxEmulator)]
+[ConditionalClass(typeof(CosmosTestEnvironment), nameof(CosmosTestEnvironment.IsNotLinuxEmulator))]
 public class VectorSearchTranslationsCosmosTest : IClassFixture<VectorSearchTranslationsCosmosTest.VectorSearchFixture>
 {
     public VectorSearchTranslationsCosmosTest(VectorSearchFixture fixture, ITestOutputHelper testOutputHelper)

test/EFCore.SqlServer.FunctionalTests/BuiltInDataTypesSqlServerTest.cs

@@ -814,7 +814,7 @@ WHERE DATEDIFF(millisecond, [m].[TimeSpanAsTime], @timeSpan) = 0
     public virtual void Can_query_using_DateDiffMicrosecond_using_TimeSpan()
     {
         using var context = CreateContext();
-        var timeSpan = new TimeSpan(2, 1, 0);
+        var timeSpan = new TimeSpan(11, 15, 13);
 
         var results
             = context.Set<MappedNullableDataTypes>()
@@ -825,7 +825,7 @@ var results
         Assert.Empty(results);
         AssertSql(
             """
-@timeSpan='02:01:00' (Nullable = true)
+@timeSpan='11:15:13' (Nullable = true)
 
 SELECT [m].[Int]
 FROM [MappedNullableDataTypes] AS [m]
@@ -837,7 +837,7 @@ WHERE DATEDIFF(microsecond, [m].[TimeSpanAsTime], @timeSpan) = 0
     public virtual void Can_query_using_DateDiffNanosecond_using_TimeSpan()
     {
         using var context = CreateContext();
-        var timeSpan = new TimeSpan(2, 1, 0);
+        var timeSpan = new TimeSpan(11, 15, 13);
 
         var results
             = context.Set<MappedNullableDataTypes>()
@@ -848,7 +848,7 @@ var results
         Assert.Empty(results);
         AssertSql(
             """
-@timeSpan='02:01:00' (Nullable = true)
+@timeSpan='11:15:13' (Nullable = true)
 
 SELECT [m].[Int]
 FROM [MappedNullableDataTypes] AS [m]

test/EFCore.SqlServer.FunctionalTests/Query/AdHocPrecompiledQuerySqlServerTest.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using Xunit.Sdk;
+
 namespace Microsoft.EntityFrameworkCore.Query;
 
 public class AdHocPrecompiledQuerySqlServerTest(NonSharedFixture fixture, ITestOutputHelper testOutputHelper)
@@ -9,9 +11,17 @@ public class AdHocPrecompiledQuerySqlServerTest(NonSharedFixture fixture, ITestO
     protected override bool AlwaysPrintGeneratedSources
         => false;
 
-    [ConditionalFact(typeof(SqlServerTestEnvironment), nameof(SqlServerTestEnvironment.SupportsJsonPathExpressions))]
-    public override async Task Index_no_evaluatability()
+        public override async Task Index_no_evaluatability()
     {
+
+        if (!SqlServerTestEnvironment.SupportsJsonPathExpressions)
+
+        {
+
+            throw SkipException.ForSkip("Requires SupportsJsonPathExpressions");
+
+        }
+
         await base.Index_no_evaluatability();
 
         AssertSql(
@@ -22,9 +32,17 @@ WHERE CAST(JSON_VALUE([j].[IntList], '$[' + CAST([j].[Id] AS nvarchar(max)) + ']
 """);
     }
 
-    [ConditionalFact(typeof(SqlServerTestEnvironment), nameof(SqlServerTestEnvironment.SupportsJsonPathExpressions))]
-    public override async Task Index_with_captured_variable()
+        public override async Task Index_with_captured_variable()
     {
+
+        if (!SqlServerTestEnvironment.SupportsJsonPathExpressions)
+
+        {
+
+            throw SkipException.ForSkip("Requires SupportsJsonPathExpressions");
+
+        }
+
         await base.Index_with_captured_variable();
 
         AssertSql(