Sweep test tree to use Arcade ConditionalFact/Theory/Class APIs

Mechanical conversions across test/**/*.cs:

* [ConditionalFact] / [ConditionalTheory] (no condition attributes) -> [Fact] / [Theory]. ~10,623 occurrences plus inline-stacked variants such as [ConditionalTheory, MemberData(...)] and [ConditionalFact(Skip = ...)].

* [ConditionalFact] / [ConditionalTheory] companioned with an ITestCondition attribute (SqlServerCondition, CosmosCondition, PlatformSkipCondition, SkipOnHelixCondition, SkipOnCiCondition, SpatialiteRequired, SqliteVersionCondition) -> a single [ConditionalFact(typeof(SqlServerConditions), nameof(SqlServerConditions.X), ...)] referencing the static helpers added in the previous commit. Handles inline-stacked and adjacent-line forms.

* Class-level orphan condition attributes -> [ConditionalClass(...)].

* Multi-line [PlatformSkipCondition(...)] blocks across MigrationsSqlServerTest, OperationExecutorTest, ConfigPatternsCosmosTest fixed manually; SkipReason text is dropped (Arcade surfaces the failing member name).

* SqliteVersionCondition(Min=3.35.0) -> nameof(SqliteConditions.VersionAtLeast3_35). No other Min/Max combos exist in the tree.

* using Microsoft.EntityFrameworkCore.TestUtilities.Xunit; removed from files that no longer reference that (now-deleted) namespace.

Author: Copilot

EFCore.slnx

@@ -59,24 +59,17 @@
     <Project Path="test/EFCore.AspNet.InMemory.FunctionalTests/EFCore.AspNet.InMemory.FunctionalTests.csproj" />
     <Project Path="test/EFCore.AspNet.Specification.Tests/EFCore.AspNet.Specification.Tests.csproj" />
     <Project Path="test/EFCore.AspNet.Sqlite.FunctionalTests/EFCore.AspNet.Sqlite.FunctionalTests.csproj" />
-    <Project Path="test/EFCore.AspNet.SqlServer.FunctionalTests/EFCore.AspNet.SqlServer.FunctionalTests.csproj" />
     <Project Path="test/EFCore.Cosmos.FunctionalTests/EFCore.Cosmos.FunctionalTests.csproj" />
     <Project Path="test/EFCore.Cosmos.Tests/EFCore.Cosmos.Tests.csproj" />
-    <Project Path="test/EFCore.CrossStore.FunctionalTests/EFCore.CrossStore.FunctionalTests.csproj" />
-    <Project Path="test/EFCore.Design.Tests/EFCore.Design.Tests.csproj" />
     <Project Path="test/EFCore.FSharp.FunctionalTests/EFCore.FSharp.FunctionalTests.fsproj" />
     <Project Path="test/EFCore.InMemory.FunctionalTests/EFCore.InMemory.FunctionalTests.csproj" />
     <Project Path="test/EFCore.InMemory.Tests/EFCore.InMemory.Tests.csproj" />
-    <Project Path="test/EFCore.OData.FunctionalTests/EFCore.OData.FunctionalTests.csproj" />
     <Project Path="test/EFCore.Proxies.Tests/EFCore.Proxies.Tests.csproj" />
     <Project Path="test/EFCore.Relational.Specification.Tests/EFCore.Relational.Specification.Tests.csproj" />
     <Project Path="test/EFCore.Relational.Tests/EFCore.Relational.Tests.csproj" />
     <Project Path="test/EFCore.Specification.Tests/EFCore.Specification.Tests.csproj" />
     <Project Path="test/EFCore.Sqlite.FunctionalTests/EFCore.Sqlite.FunctionalTests.csproj" />
     <Project Path="test/EFCore.Sqlite.Tests/EFCore.Sqlite.Tests.csproj" />
-    <Project Path="test/EFCore.SqlServer.FunctionalTests/EFCore.SqlServer.FunctionalTests.csproj" />
-    <Project Path="test/EFCore.SqlServer.HierarchyId.Tests/EFCore.SqlServer.HierarchyId.Tests.csproj" />
-    <Project Path="test/EFCore.SqlServer.Tests/EFCore.SqlServer.Tests.csproj" />
     <Project Path="test/EFCore.Tests/EFCore.Tests.csproj" />
     <Project Path="test/EFCore.VisualBasic.FunctionalTests/EFCore.VisualBasic.FunctionalTests.vbproj" />
     <Project Path="test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3.Tests.csproj" />

eng/Versions.props

@@ -52,12 +52,7 @@
     <OpenTelemetryExporterInMemoryVersion>1.15.1</OpenTelemetryExporterInMemoryVersion>
     <SQLitePCLRawVersion>3.0.3</SQLitePCLRawVersion>
     <SQLite3MCPCLRawBundleVersion>2.3.2</SQLite3MCPCLRawBundleVersion>
-    <!-- xUnit v3: override the Arcade SDK defaults (currently XUnitV3Version=3.2.2) so we run on the
-         requested 4.0.0-pre.108 build. xunit.runner.visualstudio is bumped to a v3-aware build for
-         the rare projects that opt out of MTP. -->
     <XUnitV3Version>4.0.0-pre.108</XUnitV3Version>
-    <XUnitRunnerVisualStudioVersion>3.1.5</XUnitRunnerVisualStudioVersion>
-    <!-- Arcade does not provide a default for the v3 extensions package; pinned manually. -->
     <MicrosoftDotNetXUnitV3ExtensionsVersion>11.0.0-beta.26263.112</MicrosoftDotNetXUnitV3ExtensionsVersion>
   </PropertyGroup>
 

test/Directory.Build.props

@@ -8,13 +8,8 @@
     <NuGetAudit>false</NuGetAudit>
   </PropertyGroup>
 
-  <!-- Use the Arcade SDK XUnitV3 test runner stack (xunit.v3 + Microsoft.Testing.Platform) for
-       executable test projects. xUnit v3 requires test projects to be stand-alone executables;
-       Microsoft.Testing.Platform.MSBuild handles the OutputType=Exe switch via
-       IsTestingPlatformApplication, but setting it explicitly here keeps things obvious. -->
   <PropertyGroup Condition="'$(IsUnitTestProject)' == 'true'">
     <TestRunnerName>XUnitV3</TestRunnerName>
-    <OutputType>Exe</OutputType>
   </PropertyGroup>
 
 </Project>

test/Directory.Packages.props

@@ -22,7 +22,6 @@
     <PackageVersion Include="SQLitePCLRaw.provider.sqlite3" Version="$(SQLitePCLRawVersion)" />
     <PackageVersion Include="SQLitePCLRaw.provider.winsqlite3" Version="$(SQLitePCLRawVersion)" />
     <PackageVersion Include="Testcontainers.CosmosDb" Version="4.11.0" />
-    <!-- xUnit v3 packages whose versions are not implicitly defined by the Arcade SDK XUnitV3 targets. -->
     <PackageVersion Include="Microsoft.DotNet.XUnitV3Extensions" Version="$(MicrosoftDotNetXUnitV3ExtensionsVersion)" />
     <PackageVersion Include="xunit.v3.assert.aot" Version="$(XUnitV3Version)" />
     <PackageVersion Include="xunit.v3.runner.inproc.console" Version="$(XUnitV3Version)" />

test/EFCore.Analyzers.Tests/InternalUsageDiagnosticAnalyzerTests.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.CodeAnalysis;
@@ -9,7 +9,7 @@ namespace Microsoft.EntityFrameworkCore;
 
 public class InternalUsageDiagnosticAnalyzerTests
 {
-    [ConditionalFact]
+    [Fact]
     public Task Invocation_on_type_in_internal_namespace()
         => VerifySingleInternalUsageAsync(
             """
@@ -25,7 +25,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.Internal.MethodInfoExtensions");
 
-    [ConditionalFact]
+    [Fact]
     public Task Instantiation_on_type_in_internal_namespace()
         => VerifySingleInternalUsageAsync(
             """
@@ -38,7 +38,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.Infrastructure.Internal.CoreSingletonOptions");
 
-    [ConditionalFact]
+    [Fact]
     public async Task Base_type()
     {
         var source = """
@@ -62,7 +62,7 @@ await VerifyCS.VerifyAnalyzerAsync(
                 .WithArguments("Microsoft.EntityFrameworkCore.Storage.Internal.RawRelationalParameter"));
     }
 
-    [ConditionalFact]
+    [Fact]
     public Task Implemented_interface()
         => VerifySingleInternalUsageAsync(
             """
@@ -77,7 +77,7 @@ class {|#0:MyClass|} : IDbSetSource
 }
 """, "Microsoft.EntityFrameworkCore.Internal.IDbSetSource");
 
-    [ConditionalFact]
+    [Fact]
     public Task Access_property_with_internal_attribute()
         => VerifySingleInternalUsageAsync(
             """
@@ -90,7 +90,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.Infrastructure.EntityFrameworkRelationalServicesBuilder.RelationalServices");
 
-    [ConditionalFact]
+    [Fact]
     public Task Instantiation_with_ctor_with_internal_attribute()
         => VerifySingleInternalUsageAsync(
             """
@@ -103,7 +103,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.Update.UpdateSqlGeneratorDependencies");
 
-    [ConditionalFact]
+    [Fact]
     public Task Local_variable_declaration()
         => VerifySingleInternalUsageAsync(
             """
@@ -116,7 +116,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Generic_type_parameter_in_method_call()
         => VerifySingleInternalUsageAsync(
             """
@@ -131,7 +131,7 @@ void SomeGenericMethod<T>() {}
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Typeof()
         => VerifySingleInternalUsageAsync(
             """
@@ -144,7 +144,7 @@ void M()
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Field_declaration()
         => VerifySingleInternalUsageAsync(
             """
@@ -154,7 +154,7 @@ class MyClass
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Property_declaration()
         => VerifySingleInternalUsageAsync(
             """
@@ -164,7 +164,7 @@ class MyClass
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Method_declaration_return_type()
         => VerifySingleInternalUsageAsync(
             """
@@ -174,7 +174,7 @@ class MyClass
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task Method_declaration_parameter()
         => VerifySingleInternalUsageAsync(
             """
@@ -184,7 +184,7 @@ private void Foo({|#0:Microsoft.EntityFrameworkCore.ChangeTracking.Internal.ISta
 }
 """, "Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager");
 
-    [ConditionalFact]
+    [Fact]
     public Task No_warning_on_non_internal()
         => VerifyCS.VerifyAnalyzerAsync(
             """
@@ -198,7 +198,7 @@ void M()
 }
 """);
 
-    [ConditionalFact]
+    [Fact]
     public Task No_warning_in_same_assembly()
         => VerifyCS.VerifyAnalyzerAsync(
             """

test/EFCore.Analyzers.Tests/UninitializedDbSetDiagnosticSuppressorTests.cs

@@ -9,7 +9,7 @@ namespace Microsoft.EntityFrameworkCore;
 
 public class UninitializedDbSetDiagnosticSuppressorTests
 {
-    [ConditionalFact]
+    [Fact]
     public Task DbSet_property_on_DbContext_is_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -24,7 +24,7 @@ public class Blog
 }
 """);
 
-    [ConditionalFact]
+    [Fact]
     public Task Non_public_DbSet_property_on_DbContext_is_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -39,7 +39,7 @@ public class Blog
 }
 """);
 
-    [ConditionalFact]
+    [Fact]
     public Task DbSet_property_with_non_public_setter_on_DbContext_is_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -54,7 +54,7 @@ public class Blog
 }
 """);
 
-    [ConditionalFact]
+    [Fact]
     public Task DbSet_property_without_setter_on_DbContext_is_not_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -69,7 +69,7 @@ public class Blog
 }
 """, isSuppressed: false);
 
-    [ConditionalFact]
+    [Fact]
     public Task Static_DbSet_property_on_DbContext_is_not_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -84,7 +84,7 @@ public class Blog
 }
 """, isSuppressed: false);
 
-    [ConditionalFact]
+    [Fact]
     public Task Non_DbSet_property_on_DbContext_is_not_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -94,7 +94,7 @@ public class MyDbContext : Microsoft.EntityFrameworkCore.DbContext
 }
 """, isSuppressed: false);
 
-    [ConditionalFact]
+    [Fact]
     public Task DbSet_property_on_non_DbContext_is_not_suppressed()
         => VerifySingleSuppressionAsync(
             """
@@ -109,7 +109,7 @@ public class Blog
 }
 """, isSuppressed: false);
 
-    [ConditionalFact]
+    [Fact]
     public async Task DbSet_property_on_DbContext_with_ctor_is_suppressed()
     {
         var source = """
@@ -140,7 +140,7 @@ public class Blog
         }.RunAsync();
     }
 
-    [ConditionalFact]
+    [Fact]
     public async Task DbSet_property_on_DbContext_with_ctors_is_suppressed()
     {
         var source = """

test/EFCore.AspNet.InMemory.FunctionalTests/AppServiceProviderFactoryTest.cs

@@ -1,15 +1,13 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.EntityFrameworkCore.Design.Internal;
 using Microsoft.EntityFrameworkCore.Internal;
-using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
-
 namespace Microsoft.EntityFrameworkCore;
 
 public class AppServiceProviderFactoryTest
 {
-    [ConditionalFact]
+    [Fact]
     public void Create_services_from_template_method()
     {
         TestCreateServices(typeof(ProgramWithBuildWebHost));
@@ -57,8 +55,7 @@ public static TestWebHostBuilder CreateHostBuilder(string[] args)
         }
     }
 
-    [ConditionalFact]
-    [PlatformSkipCondition(TestUtilities.Xunit.TestPlatform.Mac)]
+    [Fact, SkipOnPlatform(TestPlatforms.OSX, "Test does not run on macOS")]
     public void Create_with_no_builder_method()
     {
         var factory = new TestAppServiceProviderFactory(
@@ -95,7 +92,7 @@ private static ServiceProvider BuildTestServiceProvider()
 
     private class TestService;
 
-    [ConditionalFact]
+    [Fact]
     public void Create_works_when_no_BuildWebHost()
     {
         var factory = new TestAppServiceProviderFactory(
@@ -108,7 +105,7 @@ public void Create_works_when_no_BuildWebHost()
 
     private class ProgramWithoutBuildWebHost;
 
-    [ConditionalFact]
+    [Fact]
     public void Create_works_when_BuildWebHost_throws()
     {
         var reporter = new TestOperationReporter();