Reenable some tests on Linux Cosmos emulator

Author: AndriySvyryd

src/EFCore/Metadata/Internal/ForeignKey.cs

@@ -951,7 +951,8 @@ public virtual IDependentKeyValueFactory DependentKeyValueFactory
             if (field == null)
             {
                 EnsureReadOnly();
-                ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
+                // The principal key value factory creates the dependent key value factory
+                _ = ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
             }
 
             return field!;

src/EFCore/Metadata/RuntimeForeignKey.cs

@@ -274,7 +274,8 @@ IDependentKeyValueFactory IRuntimeForeignKey.DependentKeyValueFactory
         {
             if (_dependentKeyValueFactory == null)
             {
-                ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
+                // The principal key value factory creates the dependent key value factory
+                _ = ((IKey)PrincipalKey).GetPrincipalKeyValueFactory();
             }
             return _dependentKeyValueFactory!;
         }

test/Directory.Build.props

@@ -17,11 +17,12 @@
       Exclude tests tagged with the "failing" category. Microsoft.DotNet.XUnitV3Extensions
       attributes such as [ConditionalClass]/[ConditionalAssembly] add `category=failing` to tests
       whose condition evaluates to false; this filter is what actually skips them at the runner.
-      Plumbed through both Arcade's RunTests target (used by test.cmd / test.sh /
-      eng/common/build.* with the test switch) and the Microsoft.Testing.Platform MSBuild target
-      (used by `dotnet test` and VS Test Explorer).
+      Microsoft.Testing.Platform's targets forward TestingPlatformCommandLineArguments into
+      RunArguments before ComputeRunArguments, so this single property covers both `dotnet test`
+      (InvokeTestingPlatform) and Arcade's RunTests target (test.cmd / test.sh /
+      eng/common/build.* -test). Setting TestRunnerAdditionalArguments in addition produces
+      duplicate args and breaks MTP's ignore-exit-code option (it accepts at most one value).
     -->
-    <TestRunnerAdditionalArguments>$(TestRunnerAdditionalArguments) --filter-not-trait category=failing --ignore-exit-code 8</TestRunnerAdditionalArguments>
     <TestingPlatformCommandLineArguments>$(TestingPlatformCommandLineArguments) --filter-not-trait category=failing --ignore-exit-code 8</TestingPlatformCommandLineArguments>
   </PropertyGroup>
 

test/EFCore.Cosmos.FunctionalTests/CustomConvertersCosmosTest.cs

@@ -131,7 +131,26 @@ public override void Infer_type_mapping_from_in_subquery_to_item()
         => Assert.Throws<InvalidOperationException>(() => base.Infer_type_mapping_from_in_subquery_to_item());
 
     public override Task Can_query_custom_type_not_mapped_by_default_equality(bool async)
-        => CosmosTestHelpers.Instance.NoSyncTest(async, a => base.Can_query_custom_type_not_mapped_by_default_equality(a));
+        => CosmosTestHelpers.Instance.NoSyncTest(async, RunCustomTypeNotMappedByDefaultEqualityAsync);
+
+    // The base test seeds a SimpleCounter and only cleans up after a successful query. When the
+    // sync variant runs, .Single() throws SyncNotSupported before cleanup, leaving the seeded
+    // entity behind and causing the next iteration to fail with a 409 conflict. Delete any
+    // leftover rows before seeding to keep the test independent of execution order.
+    private async Task RunCustomTypeNotMappedByDefaultEqualityAsync(bool async)
+    {
+        await using (var context = CreateContext())
+        {
+            var existing = await context.Set<SimpleCounter>().ToListAsync();
+            if (existing.Count > 0)
+            {
+                context.RemoveRange(existing);
+                await context.SaveChangesAsync();
+            }
+        }
+
+        await base.Can_query_custom_type_not_mapped_by_default_equality(async);
+    }
 
     private void AssertSql(params string[] expected)
         => Fixture.TestSqlLoggerFactory.AssertBaseline(expected);

test/EFCore.Proxies.Tests/ChangeDetectionProxyTests.cs

@@ -320,6 +320,7 @@ private class SharedChangeContext<TEntity>(Action<EntityTypeBuilder<TEntity>> en
 
         protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
             => optionsBuilder
+                .EnableServiceProviderCaching(false)
                 .UseChangeTrackingProxies()
                 .UseInMemoryDatabase(GetType().ShortDisplayName());
 

test/EFCore.SqlServer.FunctionalTests/Query/Inheritance/TPCInheritanceQuerySqlServerFixtureBase.cs

@@ -9,4 +9,16 @@ public abstract class TPCInheritanceQuerySqlServerFixtureBase : TPCInheritanceQu
 {
     protected override ITestStoreFactory TestStoreFactory
         => SqlServerTestStoreFactory.Instance;
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext context)
+    {
+        base.OnModelCreating(modelBuilder, context);
+
+        // Start TPC sequences past the explicit seed key range to avoid PK collisions on insert.
+        if (!UseGeneratedKeys)
+        {
+            modelBuilder.HasSequence("AnimalSequence").StartsAt(10);
+            modelBuilder.HasSequence("DrinkSequence").StartsAt(10);
+        }
+    }
 }

test/EFCore.VisualBasic.FunctionalTests/NorthwindQueryVisualBasicTest.vb

@@ -3,6 +3,7 @@
 
 Imports Microsoft.EntityFrameworkCore.Query
 Imports Microsoft.EntityFrameworkCore.TestModels.Northwind
+Imports System.Threading.Tasks
 Imports Microsoft.EntityFrameworkCore.TestUtilities
 Imports Xunit
 
@@ -18,7 +19,7 @@ Partial Public Class NorthwindQueryVisualBasicTest
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub CompareString_Equals_Binary(async As Boolean)
+    Public Async Function CompareString_Equals_Binary(async As Boolean) As Task
         Await AssertQuery(
             async,
             Function(ss) ss.Set(Of Customer).Where(Function(c) c.CustomerID = "ALFKI"))
@@ -27,11 +28,11 @@ Partial Public Class NorthwindQueryVisualBasicTest
             "SELECT [c].[CustomerID], [c].[Address], [c].[City], [c].[CompanyName], [c].[ContactName], [c].[ContactTitle], [c].[Country], [c].[Fax], [c].[Phone], [c].[PostalCode], [c].[Region]
 FROM [Customers] AS [c]
 WHERE [c].[CustomerID] = N'ALFKI'")
-    End Sub
+    End Function
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub CompareString_LessThanOrEqual_Binary(async As Boolean)
+    Public Async Function CompareString_LessThanOrEqual_Binary(async As Boolean) As Task
         Await AssertQuery(
             async,
             Function(ss) ss.Set(Of Customer).Where(Function(c) c.CustomerID <= "ALFKI"))
@@ -40,11 +41,11 @@ WHERE [c].[CustomerID] = N'ALFKI'")
             "SELECT [c].[CustomerID], [c].[Address], [c].[City], [c].[CompanyName], [c].[ContactName], [c].[ContactTitle], [c].[Country], [c].[Fax], [c].[Phone], [c].[PostalCode], [c].[Region]
 FROM [Customers] AS [c]
 WHERE [c].[CustomerID] <= N'ALFKI'")
-    End Sub
+    End Function
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub AddChecked(async As Boolean)
+    Public Async Function AddChecked(async As Boolean) As Task
         Await AssertQuery(
             async,
             Function(ss) ss.Set(Of Product).Where(Function(p) p.UnitsInStock + 1 = 102))
@@ -53,11 +54,11 @@ WHERE [c].[CustomerID] <= N'ALFKI'")
             "SELECT [p].[ProductID], [p].[Discontinued], [p].[ProductName], [p].[SupplierID], [p].[UnitPrice], [p].[UnitsInStock]
 FROM [Products] AS [p]
 WHERE [p].[UnitsInStock] + CAST(1 AS smallint) = CAST(102 AS smallint)")
-    End Sub
+    End Function
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub SubtractChecked(async As Boolean)
+    Public Async Function SubtractChecked(async As Boolean) As Task
         Await AssertQuery(
             async,
             Function(ss) ss.Set(Of Product).Where(Function(p) p.UnitsInStock - 1 = 100))
@@ -66,11 +67,11 @@ WHERE [p].[UnitsInStock] + CAST(1 AS smallint) = CAST(102 AS smallint)")
             "SELECT [p].[ProductID], [p].[Discontinued], [p].[ProductName], [p].[SupplierID], [p].[UnitPrice], [p].[UnitsInStock]
 FROM [Products] AS [p]
 WHERE [p].[UnitsInStock] - CAST(1 AS smallint) = CAST(100 AS smallint)")
-    End Sub
+    End Function
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub MultiplyChecked(async As Boolean)
+    Public Async Function MultiplyChecked(async As Boolean) As Task
         Await AssertQuery(
             async,
             Function(ss) ss.Set(Of Product).Where(Function(p) p.UnitsInStock * 1 = 101))
@@ -79,11 +80,11 @@ WHERE [p].[UnitsInStock] - CAST(1 AS smallint) = CAST(100 AS smallint)")
             "SELECT [p].[ProductID], [p].[Discontinued], [p].[ProductName], [p].[SupplierID], [p].[UnitPrice], [p].[UnitsInStock]
 FROM [Products] AS [p]
 WHERE [p].[UnitsInStock] * CAST(1 AS smallint) = CAST(101 AS smallint)")
-    End Sub
+    End Function
 
     <Theory>
     <MemberData(NameOf(IsAsyncData))>
-    Public Async Sub Parameter_name_gets_sanitized(async As Boolean)
+    Public Async Function Parameter_name_gets_sanitized(async As Boolean) As Task
         Dim units = 101
         Await AssertQuery(
             async,
@@ -95,7 +96,7 @@ WHERE [p].[UnitsInStock] * CAST(1 AS smallint) = CAST(101 AS smallint)")
 SELECT [p].[ProductID], [p].[Discontinued], [p].[ProductName], [p].[SupplierID], [p].[UnitPrice], [p].[UnitsInStock]
 FROM [Products] AS [p]
 WHERE [p].[UnitsInStock] = @units")
-    End Sub
+    End Function
 
     Private Sub AssertSql(ParamArray expected As String())
         Fixture.TestSqlLoggerFactory.AssertBaseline(expected)