Rename TypeTesters→TypeQueries, ExprHelpers→ExprTransforms, tighten ExprShapeQueries→ExprAnalysis

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: T-Gro

src/Compiler/TypedTree/TypedTreeOps.ExprConstruction.fs

@@ -583,7 +583,7 @@ module internal CollectionTypes =
             ||> List.foldBack (fun (x, y) acc -> acc.Add(x, y))
 
 [<AutoOpen>]
-module internal TypeTesters =
+module internal TypeQueries =
 
     //--------------------------------------------------------------------------
     // From Ref_private to Ref_nonlocal when exporting data.
@@ -1348,6 +1348,18 @@ module internal TypeTesters =
 
              not isStructural))
 
+    let useGenuineField (tycon: Tycon) (f: RecdField) =
+        Option.isSome f.LiteralValue
+        || tycon.IsEnumTycon
+        || f.rfield_secret
+        || (not f.IsStatic && f.rfield_mutable && not tycon.IsRecordTycon)
+
+    let ComputeFieldName tycon f =
+        if useGenuineField tycon f then
+            f.rfield_id.idText
+        else
+            CompilerGeneratedName f.rfield_id.idText
+
 
 [<AutoOpen>]
 module internal CommonContainers =

src/Compiler/TypedTree/TypedTreeOps.ExprConstruction.fsi

@@ -382,7 +382,7 @@ module internal CollectionTypes =
         static member OfList: (TyconRef * 'T) list -> TyconRefMultiMap<'T>
 
 [<AutoOpen>]
-module internal TypeTesters =
+module internal TypeQueries =
 
     /// Try to create a EntityRef suitable for accessing the given Entity from another assembly
     val tryRescopeEntity: CcuThunk -> Entity -> EntityRef voption
@@ -648,6 +648,10 @@ module internal TypeTesters =
     /// Determine if a value is a method implementing an interface dispatch slot using a private method impl
     val ComputeUseMethodImpl: g: TcGlobals -> v: Val -> bool
 
+    val useGenuineField: Tycon -> RecdField -> bool
+
+    val ComputeFieldName: Tycon -> RecdField -> string
+
 [<AutoOpen>]
 module internal CommonContainers =
 

src/Compiler/TypedTree/TypedTreeOps.ExprOps.fs

@@ -1691,7 +1691,7 @@ module internal Makers =
         mkCond DebugPointAtBinding.NoneAtInvisible m g.unit_ty e1 e2 (mkUnit g m)
 
 [<AutoOpen>]
-module internal ExprHelpers =
+module internal ExprTransforms =
 
     //--------------------------------------------------------------------------
     // tupled lambda --> method/function with a given valReprInfo specification.

src/Compiler/TypedTree/TypedTreeOps.ExprOps.fsi

@@ -506,7 +506,7 @@ module internal Makers =
     val mkUnionCaseTest: TcGlobals -> Expr * UnionCaseRef * TypeInst * range -> Expr
 
 [<AutoOpen>]
-module internal ExprHelpers =
+module internal ExprTransforms =
 
     /// Given a lambda expression taking multiple variables, build a corresponding lambda taking a tuple
     val MultiLambdaToTupledLambda: TcGlobals -> Val list -> Expr -> Val * Expr

src/Compiler/TypedTree/TypedTreeOps.Remapping.fs

@@ -2439,7 +2439,7 @@ module internal ExprRemapping =
         remapExprImpl ctxt CloneAll (mkInstRemap tpinst) e
 
 [<AutoOpen>]
-module internal ExprShapeQueries =
+module internal ExprAnalysis =
 
     //--------------------------------------------------------------------------
     // Replace Marks - adjust debugging marks when a lambda gets
@@ -2591,18 +2591,6 @@ module internal ExprShapeQueries =
 
         (recdFieldOfExnDefRefByIdx ecref n).IsMutable
 
-    let useGenuineField (tycon: Tycon) (f: RecdField) =
-        Option.isSome f.LiteralValue
-        || tycon.IsEnumTycon
-        || f.rfield_secret
-        || (not f.IsStatic && f.rfield_mutable && not tycon.IsRecordTycon)
-
-    let ComputeFieldName tycon f =
-        if useGenuineField tycon f then
-            f.rfield_id.idText
-        else
-            CompilerGeneratedName f.rfield_id.idText
-
     //---------------------------------------------------------------------------
     // Witnesses
     //---------------------------------------------------------------------------

src/Compiler/TypedTree/TypedTreeOps.Remapping.fsi

@@ -258,7 +258,7 @@ module internal ExprRemapping =
     val remapTyconExnInfo: RemapContext -> Remap -> ExceptionInfo -> ExceptionInfo
 
 [<AutoOpen>]
-module internal ExprShapeQueries =
+module internal ExprAnalysis =
 
     /// Adjust marks in expressions, replacing all marks by the given mark.
     /// Used when inlining.
@@ -274,10 +274,6 @@ module internal ExprShapeQueries =
 
     val isExnFieldMutable: TyconRef -> int -> bool
 
-    val useGenuineField: Tycon -> RecdField -> bool
-
-    val ComputeFieldName: Tycon -> RecdField -> string
-
     val GenWitnessArgTys: TcGlobals -> TraitWitnessInfo -> TType list list
 
     val GenWitnessTys: TcGlobals -> TraitWitnessInfos -> TType list