Commit 6d03772
Fix 4 fact-level bugs flagged by reviewer; bump pipe-row budget
Sonnet's v5 fact-finding pass identified four real issues not visible
to the other two reviewers:
Doc:
- ASM_Validate had a single success-edge to create-pull-request with
no failure path. Source CAN fail audits and abort. Insert
ASM_AuditPassed <<choice>> with the audit-failed branch routing to
ASM_Noop.
- LFF_NoopComment conflated three structurally distinct outcomes
(not-confirmed-flake, author-introduced-test guard, all-iterations-
failed) into one terminal labeled 'add-comment explaining skip OR
noop' — ambiguous. Rename to LFF_SkipExplain and make the
comment-on-skip unambiguous.
- Count mismatch: prose said 'repo-assist's 9 safe-outputs' but the
table shows 8 (noop is suppressed per the global note). Disambiguate
as '9 safe-outputs (8 in table + noop)'.
- Concurrency and timeout-minutes were entirely unmentioned despite
being operationally critical (RPS 30 min, LPM 90 min serialized,
LPSS 15 min serialized, LFF 60 min serialized by failing_test).
Add a 6-row Operational limits table after Overview.
Generator:
- Rule 42 pipe-row hard limit bumped from 80 to 100. Original limit
was a heuristic; the operational-limits table delivers real facts
the budget should accommodate. Doc total-lines limit (600) and
per-table limit (25 rows) unchanged.
Metrics: 566 -> 582 lines (+16, within 600 limit); 78 -> 86 pipe
rows (within new 100 limit); 0 edge labels over 80 chars; 6/6
mermaid blocks render.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b11626a commit 6d03772
2 files changed
Lines changed: 24 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
63 | 76 | | |
64 | 77 | | |
65 | 78 | | |
| |||
92 | 105 | | |
93 | 106 | | |
94 | 107 | | |
95 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
96 | 112 | | |
97 | 113 | | |
98 | 114 | | |
| |||
151 | 167 | | |
152 | 168 | | |
153 | 169 | | |
154 | | - | |
| 170 | + | |
155 | 171 | | |
156 | 172 | | |
157 | 173 | | |
158 | | - | |
| 174 | + | |
159 | 175 | | |
160 | 176 | | |
161 | 177 | | |
162 | | - | |
| 178 | + | |
163 | 179 | | |
164 | 180 | | |
165 | 181 | | |
| |||
169 | 185 | | |
170 | 186 | | |
171 | 187 | | |
172 | | - | |
| 188 | + | |
173 | 189 | | |
174 | 190 | | |
175 | 191 | | |
| |||
337 | 353 | | |
338 | 354 | | |
339 | 355 | | |
340 | | - | |
| 356 | + | |
341 | 357 | | |
342 | 358 | | |
343 | 359 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | | - | |
| 291 | + | |
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
| |||
515 | 515 | | |
516 | 516 | | |
517 | 517 | | |
518 | | - | |
| 518 | + | |
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
| |||
0 commit comments