Fix ICE in BuildDisposableCleanup when Dispose extension methods are in scope (#19568)

* Initial plan

* Fix ICE in BuildDisposableCleanup when Dispose extension methods are in scope

Use AtMostOneResult to leverage existing intrinsic-over-extension priority in
AllMethInfosOfTypeInScope, matching how regular method calls resolve Dispose.

Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/ebba43f1-81b6-417c-9138-f5867056fd94

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>

Author: Copilot

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@@ -39,6 +39,7 @@
 * Fix methods being tagged as `Member` instead of `Method` in tooltips. ([Issue #10540](https://github.com/dotnet/fsharp/issues/10540), [PR #19507](https://github.com/dotnet/fsharp/pull/19507))
 * Fix Debug-mode compilation when mixing resumable and standard computation expressions. ([Issue #19625](https://github.com/dotnet/fsharp/issues/19625), [PR #19630](https://github.com/dotnet/fsharp/pull/19630))
 * IlxGen: fix missing CompilationMapping attribute for generic values ([PR #19643](https://github.com/dotnet/fsharp/pull/19643))
+* Fix internal compiler error in `use` bindings when a C#-style `Dispose` extension method is in scope alongside `IDisposable.Dispose`. ([Issue #19552](https://github.com/dotnet/fsharp/issues/19552), [PR #19568](https://github.com/dotnet/fsharp/pull/19568))
 * Fix signature generation: single-case struct DU gets spurious bar causing FS0300. ([Issue #19597](https://github.com/dotnet/fsharp/issues/19597), [PR #19609](https://github.com/dotnet/fsharp/pull/19609))
 * Fix signature generation: backticked active pattern case names lose escaping. ([Issue #19592](https://github.com/dotnet/fsharp/issues/19592), [PR #19609](https://github.com/dotnet/fsharp/pull/19609))
 * Fix signature generation: `namespace global` header dropped from generated signature. ([Issue #19593](https://github.com/dotnet/fsharp/issues/19593), [PR #19609](https://github.com/dotnet/fsharp/pull/19609))

src/Compiler/Checking/Expressions/CheckExpressions.fs

@@ -3155,7 +3155,7 @@ let BuildDisposableCleanup (cenv: cenv) env m (v: Val) =
     v.SetHasBeenReferenced()
 
     let disposeMethod =
-        match TryFindIntrinsicOrExtensionMethInfo ResultCollectionSettings.AllResults cenv env m ad "Dispose" g.system_IDisposable_ty with
+        match TryFindIntrinsicOrExtensionMethInfo ResultCollectionSettings.AtMostOneResult cenv env m ad "Dispose" g.system_IDisposable_ty with
         | [x] -> x
         | _ -> error(InternalError(FSComp.SR.tcCouldNotFindIDisposable(), m))
 

tests/FSharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBindings.fs

@@ -45,3 +45,29 @@ module UseBindings =
         |> asFsx
         |> compile
         |> shouldSucceed
+
+    [<Fact>]
+    let ``use binding does not ICE when Dispose extension method is in scope`` () =
+        FSharp """
+open System
+open System.Runtime.CompilerServices
+
+type Disposable() =
+    interface IDisposable with
+        member _.Dispose() = ()
+
+[<Extension>]
+type PublicExtensions =
+    [<Extension>]
+    static member inline Dispose(this: #IDisposable) =
+        this
+
+let foo() =
+    use a = new Disposable()
+    ()
+
+foo()
+        """
+        |> asExe
+        |> compile
+        |> shouldSucceed