Skip to content

Commit ab7b03c

Browse files
Copilotabonie
andauthored
Add release notes and inline comments for property filter parameters
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/1d6d6e17-b57c-435f-b144-0d3146d9cbd8 Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
1 parent ef205ae commit ab7b03c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
### Fixed
22

3+
* Fix missing "No implementation was given" error when F# class inherits from a C# class with `abstract override` members without providing an implementation. ([Issue #7776](https://github.com/dotnet/fsharp/issues/7776), [PR #19503](https://github.com/dotnet/fsharp/pull/19503))
34
* Fix CLIEvent properties to be correctly recognized as events: `IsEvent` returns `true` and `XmlDocSig` uses `E:` prefix instead of `P:`. ([Issue #10273](https://github.com/dotnet/fsharp/issues/10273), [PR #18584](https://github.com/dotnet/fsharp/pull/18584))
45
* Fix extra sequence point at the end of match expressions. ([Issue #12052](https://github.com/dotnet/fsharp/issues/12052), [PR #19278](https://github.com/dotnet/fsharp/pull/19278))
56
* Fix wrong sequence point range for `return`/`yield`/`return!`/`yield!` inside computation expressions. ([Issue #19248](https://github.com/dotnet/fsharp/issues/19248), [PR #19278](https://github.com/dotnet/fsharp/pull/19278))

src/Compiler/Checking/InfoReader.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -666,8 +666,8 @@ type InfoReader(g: TcGlobals, amap: ImportMap) as this =
666666
((fun (pinfo: PropInfo) -> pinfo.IsVirtualProperty),
667667
(fun pinfo -> pinfo.IsNewSlot),
668668
(fun pinfo -> pinfo.IsDefiniteFSharpOverride),
669-
(fun _ -> false),
670-
(fun _ -> false),
669+
(fun _ -> false), // isFinal
670+
(fun _ -> false), // isAbstract
671671
PropsGetterSetterEquiv (PropInfosEquivByNameAndSig EraseNone g amap m),
672672
(fun pinfo -> pinfo.PropertyName))
673673

0 commit comments

Comments
 (0)