You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add Wave 5 delivery instructions to expert-reviewer agent
The expert-reviewer agent had 19 review dimensions and 4 analysis
waves but zero instructions about posting the review to GitHub.
Copilot would analyze thoroughly but never execute gh commands to
create inline comments on the PR.
Add Wave 5: Deliver Review as Inline Comments — mandatory final wave
that instructs the agent to post findings via gh api as a review with
inline comments at the correct file+line from the diff, deduplicate
against existing reviews, and apply the AI-reviewed label.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: .github/agents/expert-reviewer.md
+43Lines changed: 43 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -473,6 +473,49 @@ Execute review in five waves, each building on the previous.
473
473
3. Verify build and packaging correctness.
474
474
4. Confirm all test baselines are updated and explained.
475
475
476
+
### Wave 5: Deliver Review as Inline Comments
477
+
478
+
**This wave is mandatory.** Analysis without posting is worthless — the review MUST appear on the PR as posted inline comments at the correct file and line.
479
+
480
+
1.**Deduplicate first.** Check existing reviews to avoid duplicate content:
481
+
```bash
482
+
gh api repos/{owner}/{repo}/pulls/{number}/reviews --jq 'length'
483
+
```
484
+
If reviews from automated accounts already exist, skip posting and apply the label only.
485
+
486
+
2.**Post findings as a review with inline comments** at the best-fitting file and line. Use the GitHub API to create a single review with all comments:
487
+
```bash
488
+
gh api repos/{owner}/{repo}/pulls/{number}/reviews \
489
+
--method POST \
490
+
--field event=COMMENT \
491
+
--field 'body=Expert AI review — see inline comments for findings.' \
492
+
--field 'comments=[
493
+
{"path":"src/Compiler/Checking/CheckDeclarations.fs","line":2750,"body":"**[Test Coverage]** This code path lacks a test. Add a test exercising this branch."},
494
+
{"path":"src/Compiler/CodeGen/IlxGen.fs","line":1234,"body":"**[IL Emission]** Call `stripTyEqns` before this match to handle type abbreviations."}
495
+
]'
496
+
```
497
+
Each comment needs:
498
+
-`path`: file path relative to repo root (from the diff)
499
+
-`line`: line number in the **new** version of the file (right side of diff)
500
+
-`body`: severity tag in `**[Dimension]**` format, the issue, and suggested fix
501
+
502
+
3.**If no significant issues found**, post an approving review:
0 commit comments